-
Notifications
You must be signed in to change notification settings - Fork 298
Added read-only tool annotations & --read-only CLI flag #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…into readonly-mode
|
@microsoft-github-policy-service agree |
| if (isReadOnlyMode) { | ||
| for (const tool of registeredTools) { | ||
| if (!tool.annotations?.readOnlyHint) { | ||
| tool.remove(); | ||
| } | ||
| } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a better way to do it without making too many changes :(
|
Read-only tools (47):
add/update/delete tools (26):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pausing to review and see if we can simplify a few things—there are quite a lot of changes. Feel free to reach out early next week if it hasn’t moved forward.
|
@Novaes
If you in general don't agree with some solution parts, please let me know |

--read-onlyCLI flag to filter write toolsreadOnlyHint == true& read-only mode enabledGitHub issue number
#571
Associated Risks
readOnlyHintannotation is incorrectly placed in some toolsreadOnlyHintAnnotation omitted for tool, by default it's considered asfalse(write)✅ PR Checklist
🧪 How did you test it?
--read-onlyflag in arguments