Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF_BUILD environment variable missing from container job #2039

Closed
gitfool opened this issue Jan 7, 2019 · 4 comments · Fixed by #2040
Closed

TF_BUILD environment variable missing from container job #2039

gitfool opened this issue Jan 7, 2019 · 4 comments · Fixed by #2040
Assignees

Comments

@gitfool
Copy link

gitfool commented Jan 7, 2019

Agent Version and Platform

Version of your agent? 2.144.0

OS of the machine running the agent? Linux; Ubuntu 16.04 with Docker

VSTS Type and Version

Azure Pipelines

What's not working?

Following up from cake-build/cake#2432, the container job in Cake.Dungeon/azure-pipelines.yml#L6-L17 uses cake-build/cake and is not working as expected because the TF_BUILD environment variable has not been passed to the Docker container.

See Cake.Dungeon/#20190107.3/Docker job for all the build step environment variables, which have been logged as seen from inside the container. Note that the TF_BUILD environment variable is missing.

For comparison, Cake.Dungeon/#20190107.3/Linux job and Cake.Dungeon/#20190107.3/Windows job, are both run directly on the agent and see the TF_BUILD environment variable.

The TF_BUILD environment variable is required for Cake build to correctly detect if it is running on Azure Pipelines and affects subsequent build behavior such as only publishing artifacts when detected.

@TingluoHuang
Copy link
Contributor

@gitfool thanks for reporting this. we will fix this.

@gitfool
Copy link
Author

gitfool commented Jan 7, 2019

@TingluoHuang thanks for the fast turnaround! Any idea when it will be deployed? (I’m not sure if you’re continuously deploying to production.)

@TingluoHuang
Copy link
Contributor

it's going to be part of next agent version release, but may take a while (2/3 weeks), since the current version haven't finish release to entire service due to holiday season deployment delay.

@gitfool
Copy link
Author

gitfool commented Feb 12, 2019

FTR, workaround removed as fixed in azure pipelines agent 2.146.0 deployed ~Feb 6. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants