consume dotnet core 2.1, add win-x86 and linux-arm agent. #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliobbv
reviewed
Sep 21, 2018
| ################################################################################ | ||
| displayName: Windows Agent (x86) | ||
| queue: | ||
| name: buildDevs |
There was a problem hiding this comment.
Minor: Is it intentional that the name attribute for the x86 agent is buildDevs, but Hosted VS2017 for the x64 agent?
There was a problem hiding this comment.
yes. the hosted agent is Azure is 64 bit, i have to create a 32 bits build machine in the BuildDevs pool
There was a problem hiding this comment.
Yep, I now recall the conversation.
juliobbv
reviewed
Sep 21, 2018
| if [ $? -ne 0 ] | ||
| then | ||
| echo "'dnf' failed with exit code '$?'" | ||
| print_errormessage | ||
| exit 1 | ||
| fi | ||
| else | ||
| dnf install -y libunwind lttng-ust libcurl openssl-libs libuuid krb5-libs zlib libicu |
There was a problem hiding this comment.
Should we need to re-introduce libcurl for this distro?
There was a problem hiding this comment.
libcurl is still installed in line 154
|
Left a couple of comments that can be addressed with a later PR. Overall the PR LGTM. |
juliobbv
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.