Update TF.exe and binding redirects for vstshost
#4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * Refactoring * Refactor tool download code * Refactor + Add tests * Fix test * Change RetryOptions to record to be able to use default ToString override for logging --------- Co-authored-by: v-levockina <undefined> Co-authored-by: Kirill Ivlev <102740624+kirill-ivlev@users.noreply.github.com>
kirill-ivlev
approved these changes
Sep 13, 2024
vmapetr
approved these changes
Sep 13, 2024
DergachevE
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WI
AB#2138625
Description
Re-introduce this PR: #4955 with the fix of
LegacyVSTSPowerShellHost's binding redirects forNewtonsoft.Json. It should fix the incompatibility betweentfandvstsomandvstshostbinaries.Tested with VsTest@0 task which runs on the legacy Powershell handler (with
AGENT_INSTALL_LEGACY_TF_EXEknob both enabled and disabled)