Avoid constructing NetworkCredential objects on macOS machines #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-toman
changed the title
martin-toman
changed the title
martin-toman
changed the title
| ClientCertificatePassword = cerdStore.Read($"VSTS_AGENT_CLIENT_CERT_PASSWORD_{certSetting.ClientCertPasswordLookupKey}").Password; | ||
| var avoidNetCredentialFF = AgentKnobs.AvoidNetCredentialObjectsOnMac.GetValue(HostContext).AsBoolean(); | ||
| var target = $"VSTS_AGENT_CLIENT_CERT_PASSWORD_{certSetting.ClientCertPasswordLookupKey}"; | ||
| ClientCertificatePassword = avoidNetCredentialFF ? cerdStore.Read2(target).Password : cerdStore.Read(target).Password; |
There was a problem hiding this comment.
I think FF check can be removed here and directly Read2 can be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers who use macOS agents behind an HTTP proxy suffer from malloc-related crashes described in dotnet/runtime#97966. The crash does not happen immediately, but after a few jobs are executed by the Agent.
When an HTTP proxy is configured, the Agent code creates NetworkCredential objects to pass basic auth creds.
From stack trace posted in the above issue, it sounds like the crash happens when internal .NET networking objects are being released/disposed. That could explain why customers are able to execute a few jobs ok - the crash happens when GC kicks in.