Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IISWebAppMgmtV3 - Bypass bindings with duplicate certificates & support multiple certificates #1220

Conversation

v-venunayira
Copy link
Contributor

@v-venunayira v-venunayira commented Jan 12, 2024

Description: Bypassing addition of SSL binding with an existing certificate.

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: #919

Checklist:

  • Version was bumped - please check that version of the extension, task or library has been bumped.
  • Checked that applied changes work as expected.
  • Gulp build
  • Gulp test

Copy link
Contributor

@v-mohithgc v-mohithgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @LeftTwixWand can you confirm if bumping of task version for V1 and V2 is required?

@LeftTwixWand
Copy link
Contributor

LGTM, but @LeftTwixWand can you confirm if bumping of task version for V1 and V2 is required?
Hey @v-mohithgc it's not required, but it would be good to have the same version for all the tasks, just not to mess up in case of a problem.

@v-mohithgc v-mohithgc merged commit f670adb into microsoft:master Feb 1, 2024
2 checks passed
@jabteles
Copy link

jabteles commented Feb 2, 2024

Hey @LeftTwixWand and thanks for this fix! But when will it be available as a release in the Azure/Visual Studio Marketplace so we can download to our on-premises installations?

@LeftTwixWand
Copy link
Contributor

Hello @jabteles we've just released a new version of the extension.
The ADO should automatically catch up the update of the extension and install it.

@jabteles
Copy link

jabteles commented Feb 2, 2024

Hello @jabteles we've just released a new version of the extension. The ADO should automatically catch up the update of the extension and install it.

I updated the extension on my Azure DevOps and still get the same error. I've confirmed it is using correct version (3.2.0)

@naillatem
Copy link

The extension fails on target server from other localizations. Parsing the nesth http show sslcert command output with an unlocalized string, like "IP:port" doesn't work on target servers with different localization configuration (i.e. spanish output shows "IP:puerto", and Add-SslCert function fails when trying to add an existing certificate binding).

@PhilBlackRose
Copy link

@v-schhabra Thanks for hint to try this to fix issues with IIS web deploy task, This task however doesn't seem compatible with Deployment Group jobs?

@v-schhabra
Copy link

Hello @jabteles we've just released a new version of the extension. The ADO should automatically catch up the update of the extension and install it.

I updated the extension on my Azure DevOps and still get the same error. I've confirmed it is using correct version (3.2.0)

@jabteles Could you share the logs of the pipeline by adding variable system.debug to "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants