Skip to content

Commit

Permalink
Replace sync-request with nodejs-file-downloader (#19769)
Browse files Browse the repository at this point in the history
* Replace sync-request with nodejs-file-downloader

- Replaced sync-request with nodejs-file-downloader because the package is not supported anymore
- Replaced sync methods with async because nodejs-file-downloader and nodejs makes only async requests

* build task locally using node 20.11.0 and npm 10

* bump up versions

* regenerate package-lock for DownloadGitHubReleaseV0

* Revert "bump up versions"

This reverts commit d6446cc.

* Revert "regenerate package-lock for DownloadGitHubReleaseV0"

This reverts commit e4021c9.

* Revert "build task locally using node 20.11.0 and npm 10"

This reverts commit 2c3a8d5.

* Download node for windows with npm

* Download node for windows with npm

* Optimize build config calls

* Optimize determination of node version

* Fix uncommitted changes

* Replace sync-request with nodejs-file-downloader

- use node 10 as default for non-node tasks
- bump tasks version

---------

Co-authored-by: Zixuan Qian <zqian@microsoft.com>
  • Loading branch information
DmitriiBobreshev and qianz2 authored Apr 15, 2024
1 parent b4017a7 commit 0e190cd
Show file tree
Hide file tree
Showing 26 changed files with 2,461 additions and 1,429 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"loc.friendlyName": "Delay",
"loc.helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?linkid=870239)",
"loc.helpMarkDown": "[Learn more about this task](https://go.microsoft.com/fwlink/?linkid=870239)",
"loc.description": "Delay further execution of a workflow by a fixed time",
"loc.instanceNameFormat": "Delay by $(delayForMinutes) minutes",
"loc.input.label.delayForMinutes": "Delay Time (minutes)",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DelayV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
],
"version": {
"Major": 1,
"Minor": 1,
"Patch": 10
"Minor": 238,
"Patch": 0
},
"inputs": [
{
Expand Down
4 changes: 2 additions & 2 deletions Tasks/DelayV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
],
"version": {
"Major": 1,
"Minor": 1,
"Patch": 10
"Minor": 238,
"Patch": 0
},
"inputs": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"loc.friendlyName": "IIS web app manage",
"loc.helpMarkDown": "[More Information](https://aka.ms/iis-webapp-management-readme)",
"loc.helpMarkDown": "[Learn more about this task](https://aka.ms/iis-webapp-management-readme)",
"loc.description": "Create or update websites, web apps, virtual directories, or application pools",
"loc.instanceNameFormat": "Manage $(IISDeploymentType)",
"loc.group.displayName.Website": "IIS Website",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/IISWebAppManagementOnMachineGroupV0/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"demands": [],
"version": {
"Major": 0,
"Minor": 198,
"Minor": 238,
"Patch": 0
},
"minimumAgentVersion": "2.111.0",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/IISWebAppManagementOnMachineGroupV0/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"demands": [],
"version": {
"Major": 0,
"Minor": 198,
"Minor": 238,
"Patch": 0
},
"minimumAgentVersion": "2.111.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"loc.friendlyName": "Manual intervention",
"loc.helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?linkid=870234)",
"loc.helpMarkDown": "[Learn more about this task](https://go.microsoft.com/fwlink/?linkid=870234)",
"loc.description": "Pause deployment and wait for manual intervention",
"loc.instanceNameFormat": "Manual Intervention",
"loc.input.label.instructions": "Instructions",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/ManualInterventionV8/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"version": {
"Major": 8,
"Minor": 198,
"Minor": 238,
"Patch": 0
},
"inputs": [
Expand Down
2 changes: 1 addition & 1 deletion Tasks/ManualInterventionV8/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"version": {
"Major": 8,
"Minor": 198,
"Minor": 238,
"Patch": 0
},
"inputs": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
"loc.helpMarkDown": "[Learn more about this task](https://aka.ms/manual-validation)",
"loc.description": "[PREVIEW] Pause a pipeline run to wait for manual interaction. Works only with YAML pipelines.",
"loc.instanceNameFormat": "Manual Validation",
"loc.input.label.validators": "Notify users",
"loc.input.help.validators": "Send a manual validation pending email to specific users (or groups). Only users with queue build permission can act on a manual validation.",
"loc.input.label.notifyUsers": "Notify users",
"loc.input.help.notifyUsers": "Send a manual validation pending email to specific users (or groups). Only users with queue build permission can act on a manual validation.",
"loc.input.label.instructions": "Instructions",
"loc.input.help.instructions": "These instructions will be shown to the user for resuming or rejecting the manual validation. Based on these instructions the user will take an informed decision about this manual validation.",
"loc.input.label.onTimeout": "On timeout",
"loc.input.label.onTimeoutReject": "Reject",
"loc.input.label.onTimeoutResume": "Resume",
"loc.input.help.onTimeout": "Reject or resume this manual validation automatically after it is pending for the specified timeout or 30 days, whichever is earlier."
}
2 changes: 1 addition & 1 deletion Tasks/ManualValidationV0/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"version": {
"Major": 0,
"Minor": 198,
"Minor": 238,
"Patch": 0
},
"preview": true,
Expand Down
14 changes: 7 additions & 7 deletions Tasks/ManualValidationV0/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@
],
"version": {
"Major": 0,
"Minor": 198,
"Minor": 238,
"Patch": 0
},
"preview": true,
"inputs": [
{
"name": "notifyUsers",
"type": "multiLine",
"label": "ms-resource:loc.input.label.validators",
"label": "ms-resource:loc.input.label.notifyUsers",
"defaultValue": "",
"required": true,
"helpMarkDown": "ms-resource:loc.input.help.validators"
"helpMarkDown": "ms-resource:loc.input.help.notifyUsers"
},
{
"name": "instructions",
Expand All @@ -44,12 +44,12 @@
{
"name": "onTimeout",
"type": "radio",
"label": "loc.input.label.onTimeout",
"defaultValue": "loc.input.label.onTimeoutReject",
"label": "ms-resource:loc.input.label.onTimeout",
"defaultValue": "reject",
"required": false,
"options": {
"reject": "loc.input.label.onTimeoutReject",
"resume": "loc.input.label.onTimeoutResume"
"reject": "Reject",
"resume": "Resume"
},
"helpMarkDown": "ms-resource:loc.input.help.onTimeout"
}
Expand Down
Loading

0 comments on commit 0e190cd

Please sign in to comment.