[JavaToolInstaller] Fixed code review points.

microsoft · Jul 8, 2020 · 649d42a · 649d42a
1 parent 2f157e8
commit 649d42a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Tasks/JavaToolInstallerV0/FileExtractor/JavaFilesExtractor.ts b/Tasks/JavaToolInstallerV0/FileExtractor/JavaFilesExtractor.ts
@@ -11,6 +11,7 @@ interface IDirectoriesDictionary {
 }
 
 export class JavaFilesExtractor {
+ readonly ERR_SHARE_ACCESS = -4094;
  public destinationFolder: string;
  public readonly win: boolean;
 
@@ -171,12 +172,11 @@ export class JavaFilesExtractor {
 
  const jdkFile = path.normalize(repoRoot);
 
- const ERR_SHARE_ACCESS = -4094;
- let stats;
+ let stats: taskLib.FsStats;
  try {
  stats = taskLib.stats(jdkFile);
  } catch (error) {
- if (error.errno === ERR_SHARE_ACCESS) {
+ if (error.errno === this.ERR_SHARE_ACCESS) {
  throw new Error(taskLib.loc('ShareAccessError', error.path));
  }
  throw(error);

diff --git a/Tasks/JavaToolInstallerV0/task.json b/Tasks/JavaToolInstallerV0/task.json
@@ -178,6 +178,6 @@
  "JavaNotPreinstalled": "Java %s is not preinstalled on this agent",
  "UsePreinstalledJava": "Use preinstalled JDK from %s",
  "WrongArchiveStructure": "JDK file is not valid. Verify if JDK file contains only one root folder with 'bin' inside.",
- "ShareAccessError": "Network shared resource not available (%s)"
+ "ShareAccessError": "Network shared resource not available: (%s)"
  }
 }