Skip to content

Commit

Permalink
Responding to PR feedback.
Browse files Browse the repository at this point in the history
- no need to log inputs, getInput does that
- don't use tl.exit, use setResult
  • Loading branch information
jpricket committed May 16, 2016
1 parent 90ac5d8 commit dec1b9c
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions Tasks/XamariniOS/xamarinios.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,9 @@ var args = tl.getInput('args');
var packageApp = tl.getBoolInput('packageApp');
var buildForSimulator = tl.getBoolInput('forSimulator');
var device = (buildForSimulator) ? 'iPhoneSimulator' : 'iPhone';
tl.debug('device: ' + device);
var xbuildLocation = tl.getInput('mdtoolLocation', false);
var cwd = tl.getInput('cwd');
tl.debug('solution: ' + solutionPath);
tl.debug('configuration: ' + configuration);
tl.debug('args: ' + args);
tl.debug('packageApp: ' + packageApp);
tl.debug('buildForSimulator: ' + buildForSimulator);
tl.debug('device: ' + device);
tl.debug('xbuildLocation: ' + xbuildLocation);
tl.debug('cwd: ' + cwd);

// Get path to xbuild
var xbuildToolPath = undefined;
Expand Down Expand Up @@ -149,11 +142,11 @@ nugetRunner.exec()
tl.exit(code);
})
} else {
tl.exit(0);
tl.setResult(tl.TaskResult.Succeeded, '');
}
})
} else {
tl.exit(0);
tl.setResult(tl.TaskResult.Succeeded, '');
}

})
Expand Down

0 comments on commit dec1b9c

Please sign in to comment.