Skip to content

Commit

Permalink
Remove SAS reference from readme (#20450)
Browse files Browse the repository at this point in the history
  • Loading branch information
v-snalawade authored Sep 23, 2024
1 parent e37b9a7 commit f244f13
Show file tree
Hide file tree
Showing 15 changed files with 79 additions and 91 deletions.
4 changes: 1 addition & 3 deletions Tasks/AzureFileCopyV6/PreJobExecutionAzureFileCopy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ async function run(): Promise<void> {
const storageArmClient = new armStorage.StorageManagementClient(azureEndpoint.applicationTokenCredentials, azureEndpoint.subscriptionID);
let storageAccount: StorageAccount = await storageArmClient.storageAccounts.get(storageAccountName);
let storageAccountResourceGroupName = getResourceGroupNameFromUri(storageAccount.id);
let accessKeys = await storageArmClient.storageAccounts.listKeys(storageAccountResourceGroupName, storageAccountName, null);
let accessKey: string = accessKeys[0];
let data: string = `/DestKey:\"${accessKey}\"`;
let data: string = `/DestKey:\"\"`;
let options = { encoding : "utf8" }
fs.writeFileSync(file, data, options);
tl.setTaskVariable('AFC_V2_ARM_STORAGE_KEY_FILE', file);
Expand Down
2 changes: 0 additions & 2 deletions Tasks/AzureFileCopyV6/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ The parameters of the task are described in details, including examples, to show

The task creates the following as output variables:
* **StorageContainerUri**: When copying files to an Azure container, this parameter returns the Uri of the container were the files were copied to.
* **StorageContainerSasToken**: When copying files to an Azure container, a SasToken is created and returned. By default, this token expires after 4 hours.

Following the [output variables](https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#use-output-variables-from-tasks) documentation and naming the step, we can then reference the variables like so:

Expand All @@ -104,7 +103,6 @@ Following the [output variables](https://docs.microsoft.com/en-us/azure/devops/p

- script: |
echo $(AzureFileCopy.StorageContainerUri)
echo $(AzureFileCopy.StorageContainerSasToken)
```
### Known Limitations :
Expand Down
54 changes: 27 additions & 27 deletions Tasks/AzureFileCopyV6/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tasks/AzureFileCopyV6/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 6,
"Minor": 245,
"Patch": 2
"Minor": 246,
"Patch": 0
},
"demands": [
"azureps"
Expand Down
4 changes: 2 additions & 2 deletions Tasks/AzureFileCopyV6/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 6,
"Minor": 245,
"Patch": 2
"Minor": 246,
"Patch": 0
},
"demands": [
"azureps"
Expand Down
4 changes: 2 additions & 2 deletions _generated/AzureFileCopyV6.versionmap.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Default|6.245.2
Node20_229_2|6.245.3
Default|6.246.0
Node20_229_2|6.246.1
4 changes: 1 addition & 3 deletions _generated/AzureFileCopyV6/PreJobExecutionAzureFileCopy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ async function run(): Promise<void> {
const storageArmClient = new armStorage.StorageManagementClient(azureEndpoint.applicationTokenCredentials, azureEndpoint.subscriptionID);
let storageAccount: StorageAccount = await storageArmClient.storageAccounts.get(storageAccountName);
let storageAccountResourceGroupName = getResourceGroupNameFromUri(storageAccount.id);
let accessKeys = await storageArmClient.storageAccounts.listKeys(storageAccountResourceGroupName, storageAccountName, null);
let accessKey: string = accessKeys[0];
let data: string = `/DestKey:\"${accessKey}\"`;
let data: string = `/DestKey:\"\"`;
let options = { encoding : "utf8" }
fs.writeFileSync(file, data, options);
tl.setTaskVariable('AFC_V2_ARM_STORAGE_KEY_FILE', file);
Expand Down
2 changes: 0 additions & 2 deletions _generated/AzureFileCopyV6/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ The parameters of the task are described in details, including examples, to show

The task creates the following as output variables:
* **StorageContainerUri**: When copying files to an Azure container, this parameter returns the Uri of the container were the files were copied to.
* **StorageContainerSasToken**: When copying files to an Azure container, a SasToken is created and returned. By default, this token expires after 4 hours.

Following the [output variables](https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#use-output-variables-from-tasks) documentation and naming the step, we can then reference the variables like so:

Expand All @@ -104,7 +103,6 @@ Following the [output variables](https://docs.microsoft.com/en-us/azure/devops/p

- script: |
echo $(AzureFileCopy.StorageContainerUri)
echo $(AzureFileCopy.StorageContainerSasToken)
```
### Known Limitations :
Expand Down
54 changes: 27 additions & 27 deletions _generated/AzureFileCopyV6/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions _generated/AzureFileCopyV6/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 6,
"Minor": 245,
"Patch": 2
"Minor": 246,
"Patch": 0
},
"demands": [
"azureps"
Expand Down Expand Up @@ -288,7 +288,7 @@
"AzModuleNotFound": "Could not find the modules: 'Az.Accounts'. If the module was recently installed, retry after restarting the Azure Pipelines task agent."
},
"_buildConfigMapping": {
"Default": "6.245.2",
"Node20_229_2": "6.245.3"
"Default": "6.246.0",
"Node20_229_2": "6.246.1"
}
}
8 changes: 4 additions & 4 deletions _generated/AzureFileCopyV6/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 6,
"Minor": 245,
"Patch": 2
"Minor": 246,
"Patch": 0
},
"demands": [
"azureps"
Expand Down Expand Up @@ -288,7 +288,7 @@
"AzModuleNotFound": "ms-resource:loc.messages.AzModuleNotFound"
},
"_buildConfigMapping": {
"Default": "6.245.2",
"Node20_229_2": "6.245.3"
"Default": "6.246.0",
"Node20_229_2": "6.246.1"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ async function run(): Promise<void> {
const storageArmClient = new armStorage.StorageManagementClient(azureEndpoint.applicationTokenCredentials, azureEndpoint.subscriptionID);
let storageAccount: StorageAccount = await storageArmClient.storageAccounts.get(storageAccountName);
let storageAccountResourceGroupName = getResourceGroupNameFromUri(storageAccount.id);
let accessKeys = await storageArmClient.storageAccounts.listKeys(storageAccountResourceGroupName, storageAccountName, null);
let accessKey: string = accessKeys[0];
let data: string = `/DestKey:\"${accessKey}\"`;
let data: string = `/DestKey:\"\"`;
let options = { encoding : "utf8" }
fs.writeFileSync(file, data, options);
tl.setTaskVariable('AFC_V2_ARM_STORAGE_KEY_FILE', file);
Expand Down
2 changes: 0 additions & 2 deletions _generated/AzureFileCopyV6_Node20/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ The parameters of the task are described in details, including examples, to show

The task creates the following as output variables:
* **StorageContainerUri**: When copying files to an Azure container, this parameter returns the Uri of the container were the files were copied to.
* **StorageContainerSasToken**: When copying files to an Azure container, a SasToken is created and returned. By default, this token expires after 4 hours.

Following the [output variables](https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#use-output-variables-from-tasks) documentation and naming the step, we can then reference the variables like so:

Expand All @@ -104,7 +103,6 @@ Following the [output variables](https://docs.microsoft.com/en-us/azure/devops/p

- script: |
echo $(AzureFileCopy.StorageContainerUri)
echo $(AzureFileCopy.StorageContainerSasToken)
```
### Known Limitations :
Expand Down
8 changes: 4 additions & 4 deletions _generated/AzureFileCopyV6_Node20/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 6,
"Minor": 245,
"Patch": 3
"Minor": 246,
"Patch": 1
},
"demands": [
"azureps"
Expand Down Expand Up @@ -292,7 +292,7 @@
"AzModuleNotFound": "Could not find the modules: 'Az.Accounts'. If the module was recently installed, retry after restarting the Azure Pipelines task agent."
},
"_buildConfigMapping": {
"Default": "6.245.2",
"Node20_229_2": "6.245.3"
"Default": "6.246.0",
"Node20_229_2": "6.246.1"
}
}
8 changes: 4 additions & 4 deletions _generated/AzureFileCopyV6_Node20/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 6,
"Minor": 245,
"Patch": 3
"Minor": 246,
"Patch": 1
},
"demands": [
"azureps"
Expand Down Expand Up @@ -292,7 +292,7 @@
"AzModuleNotFound": "ms-resource:loc.messages.AzModuleNotFound"
},
"_buildConfigMapping": {
"Default": "6.245.2",
"Node20_229_2": "6.245.3"
"Default": "6.246.0",
"Node20_229_2": "6.246.1"
}
}

0 comments on commit f244f13

Please sign in to comment.