add property to restrict approver from approving their own run (#20593)

microsoft · Nov 5, 2024 · fc04f86 · fc04f86
1 parent 2b2d81c
commit fc04f86
Show file tree

Hide file tree

Showing 4 changed files with 1,181 additions and 2,252 deletions.
diff --git a/Tasks/ManualValidationV1/Strings/resources.resjson/en-US/resources.resjson b/Tasks/ManualValidationV1/Strings/resources.resjson/en-US/resources.resjson
@@ -7,6 +7,8 @@
   "loc.input.help.notifyUsers": "Send a manual validation pending email to specific users (or groups). Only users specified in approvers can act on a manual validation.",
   "loc.input.label.approvers": "Approvers",
   "loc.input.help.approvers": "Specify users/groups/project teams separated by commas to act on a manual validation. In absence of input, users with queue build permission will be able to take action.",
+  "loc.input.label.allowApproversToApproveTheirOwnRuns": "Allow approvers to approve their own run",
+  "loc.input.help.allowApproversToApproveTheirOwnRuns": "If this is true, approver will be able to approve their own run",
   "loc.input.label.instructions": "Instructions",
   "loc.input.help.instructions": "These instructions will be shown to the user for resuming or rejecting the manual validation. Based on these instructions the user will take an informed decision about this manual validation.",
   "loc.input.label.onTimeout": "On timeout",

diff --git a/Tasks/ManualValidationV1/task.json b/Tasks/ManualValidationV1/task.json
@@ -15,7 +15,7 @@
     ],
     "version": {
         "Major": 1,
-        "Minor": 244,
+        "Minor": 248,
         "Patch": 0
     },
     "inputs": [
@@ -35,6 +35,14 @@
             "required": false,
             "helpMarkDown": "Specify users/groups/project teams separated by commas to act on a manual validation. In absence of input, users with queue build permission will be able to take action."
         },
+        {
+            "name": "allowApproversToApproveTheirOwnRuns",
+            "type": "boolean",
+            "label": "Allow approvers to approve their own run",
+            "required": false,
+            "defaultValue": "false",
+            "helpMarkDown": "If this is true, approver will be able to approve their own run"            
+        },
         {
             "name": "instructions",
             "type": "multiLine",

diff --git a/Tasks/ManualValidationV1/task.loc.json b/Tasks/ManualValidationV1/task.loc.json
@@ -15,7 +15,7 @@
   ],
   "version": {
     "Major": 1,
-    "Minor": 244,
+    "Minor": 248,
     "Patch": 0
   },
   "inputs": [
@@ -35,6 +35,14 @@
       "required": false,
       "helpMarkDown": "ms-resource:loc.input.help.approvers"
     },
+    {
+      "name": "allowApproversToApproveTheirOwnRuns",
+      "type": "boolean",
+      "label": "ms-resource:loc.input.label.allowApproversToApproveTheirOwnRuns",
+      "required": false,
+      "defaultValue": "false",
+      "helpMarkDown": "ms-resource:loc.input.help.allowApproversToApproveTheirOwnRuns"
+    },
     {
       "name": "instructions",
       "type": "multiLine",