Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output toggle for az login within the AzureCLIV2 task #16701

Merged
merged 121 commits into from
May 2, 2024

Conversation

piotr-gbyliczek
Copy link
Contributor

@piotr-gbyliczek piotr-gbyliczek commented Aug 8, 2022

Task name: AzureCLIV2

Description: Added a toggleable setting for suppressing output from az login

Documentation changes required: (Y/N) Yes

Added unit tests: (Y/N) No

Attached related issue: (Y/N) #14156

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Added `visibleAzLogin` boolean to enable hiding az login output (which can be verbose at times with all subscriptions)
Added option to both login schemes to suppress the output.
@ghost
Copy link

ghost commented Aug 8, 2022

CLA assistant check
All CLA requirements met.

@piotr-gbyliczek piotr-gbyliczek marked this pull request as ready for review August 10, 2022 11:53
@piotr-gbyliczek
Copy link
Contributor Author

It seems to be back to being ignored, any luck discussing priority on this @LeftTwixWand ?

@piotr-gbyliczek
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 16701 in repo microsoft/azure-pipelines-tasks

@LeftTwixWand
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@LeftTwixWand
Copy link
Contributor

Hey @piotr-gbyliczek I'll try to review and test this pr today. I think, we're good to go with this changes

@LeftTwixWand
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@LeftTwixWand
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@LeftTwixWand
Copy link
Contributor

Let's wait for the pipelines to be complete

@LeftTwixWand LeftTwixWand enabled auto-merge (squash) May 2, 2024 18:41
@LeftTwixWand LeftTwixWand merged commit 5278dc6 into microsoft:master May 2, 2024
11 checks passed
@LeftTwixWand
Copy link
Contributor

Hey @piotr-gbyliczek, the PR is completed, and these changes are going to be released in 1 week.
Thank you so much for your efforts in contributing to pipeline tasks!

@LeftTwixWand LeftTwixWand self-assigned this May 2, 2024
@piotr-gbyliczek
Copy link
Contributor Author

Great, thanks @LeftTwixWand

@grzmax
Copy link

grzmax commented May 28, 2024

Please add #19914. It doesn't work with federatedToken.

@LeftTwixWand
Copy link
Contributor

@grzmax I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task:AzureCLI Area:RM, Owners: @rvairavelu @manolerazvan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants