Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unique registry for ta #1934

Merged
2 commits merged into from
Jun 23, 2016
Merged

Check for unique registry for ta #1934

2 commits merged into from
Jun 23, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2016

No description provided.

@@ -30,7 +30,7 @@ function Locate-TestVersion()
{
$regPath = "HKLM:\SOFTWARE\Wow6432Node\Microsoft\DevDiv\vstf\Servicing"
}
$keys = Get-Item $regPath | %{$_.GetSubKeyNames()}
$keys = Get-ChildItem $regPath | Where-Object {$_.GetSubKeyNames() -contains "testagentcore"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if path doesn't exist. It should return empty array. just check once

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked


In reply to: 68206532 [](ancestors = 68206532)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains is case insensitive


In reply to: 68206914 [](ancestors = 68206914)

@nigurr
Copy link

nigurr commented Jun 23, 2016

task.json update? Approved

@nigurr
Copy link

nigurr commented Jun 23, 2016

:shipit:

@ghost ghost merged commit aa68daf into master Jun 23, 2016
@ghost ghost deleted the users/prmittal/vstasxs branch June 23, 2016 11:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants