Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyFilesOverSSHV0 change sequential files sending to continuous queue #19798

Merged
merged 3 commits into from
May 27, 2024
Merged

CopyFilesOverSSHV0 change sequential files sending to continuous queue #19798

merged 3 commits into from
May 27, 2024

Conversation

ivanduplenskikh
Copy link
Contributor

@ivanduplenskikh ivanduplenskikh commented Apr 22, 2024 •
edited
Loading

Task name: CopyFilesOverSSHV0

Description:

  • If contents are set as '**', the sourceFolder will be put onto a remote machine with the uploadDir method
  • If contents will be set, files are sent with continuous queue
  • Changed Q to Promise
  • Added two task's inputs: concurrentUploads, delayBetweenUploads

Documentation changes required: N

Added unit tests: N

Attached related issue: AB#2159883

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/copyfilesoversshv0-change-promises branch from 22645b3 to 1a2311e Compare April 22, 2024 09:55
@ivanduplenskikh ivanduplenskikh changed the title Change sequential exectuion to Promise.all CopyFilesOverSSHV0 change sequential exectuion to Promise.all Apr 22, 2024
@ivanduplenskikh ivanduplenskikh changed the title CopyFilesOverSSHV0 change sequential exectuion to Promise.all CopyFilesOverSSHV0 change sequential execution to promises Apr 22, 2024
@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/copyfilesoversshv0-change-promises branch from 238a5f7 to f8e1c29 Compare April 22, 2024 21:49
@ivanduplenskikh ivanduplenskikh marked this pull request as ready for review April 22, 2024 22:06
@ivanduplenskikh ivanduplenskikh requested a review from a team as a code owner April 22, 2024 22:06
@ivanduplenskikh ivanduplenskikh changed the title CopyFilesOverSSHV0 change sequential execution to promises CopyFilesOverSSHV0 change sequential execution to async Apr 22, 2024
@martin-toman martin-toman self-assigned this Apr 23, 2024
@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/copyfilesoversshv0-change-promises branch from 59e1ffa to 4840108 Compare May 10, 2024 08:28
@ivanduplenskikh ivanduplenskikh changed the title CopyFilesOverSSHV0 change sequential execution to async CopyFilesOverSSHV0 change sequential files sending to continuous queue May 10, 2024
@azure-boards Azure Boards
Copy link

azure-boards bot commented May 10, 2024

✅ Successfully linked to Azure Boards work item(s):

@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/copyfilesoversshv0-change-promises branch 9 times, most recently from 9ce6f5c to 071eb02 Compare May 20, 2024 11:26
@ivanduplenskikh ivanduplenskikh force-pushed the users/v-ivandu/copyfilesoversshv0-change-promises branch from 071eb02 to 1a3c6ad Compare May 27, 2024 14:20
@ivanduplenskikh ivanduplenskikh merged commit f6218ec into master May 27, 2024
11 checks passed
@ivanduplenskikh ivanduplenskikh deleted the users/v-ivandu/copyfilesoversshv0-change-promises branch May 27, 2024 16:02
ivanduplenskikh pushed a commit that referenced this pull request Aug 2, 2024
Update ssh2 and ssh2-sftp-client dependencies in CopyFilesOverSSH
45a7570 
This PR updates dependencies ssh2 and ssh2-sftp-client for CopyFilesOverSSH as in #19589 but now we have a queue implementation (#19798) to send all files to a remote server without performance degradation
@ivanduplenskikh ivanduplenskikh mentioned this pull request Aug 2, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlynomsft merlynomsft merlynomsft left review comments

@DmitriiBobreshev DmitriiBobreshev DmitriiBobreshev approved these changes

@vmapetr vmapetr vmapetr approved these changes

@martin-toman martin-toman martin-toman approved these changes

Assignees

@martin-toman martin-toman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivanduplenskikh @martin-toman @merlynomsft @vmapetr @DmitriiBobreshev