Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NotationV0] feat: azure-kv plugin workload identity support #19840

Merged
merged 10 commits into from
May 8, 2024
Merged

[NotationV0] feat: azure-kv plugin workload identity support #19840

merged 10 commits into from
May 8, 2024

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented May 6, 2024 •
edited
Loading

Task name: NotationV0

Description:
Feat:

  • added workload identity support for azure-kv plugin

Fix:

  • automatically override the AKV plugin version if the current version does not match the user-defined version.

Test:

  • akv plugin v1.0.1 with service principle and workload id
  • akv plugin v1.1.0 with service prinfiple and workload id
  • upgrade akv plugin from v1.0.1 to v1.1.0

Documentation changes required: (Y/N)

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@JeyJeyGao
feat: add notation akv plugin v1.1.0 support
f05f641 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update version
421c147 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
feat: support workload identity
0a09ea2 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'upstream/master' into feat/notation_wor…
35c464b 
…kload_identity
@JeyJeyGao
fix: update
59bd802 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
cf5871d 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Copy link
Collaborator Author

JeyJeyGao commented May 6, 2024 •
edited
Loading

Test pipeline issue is not related to this PR and will be solved later.

@JeyJeyGao JeyJeyGao changed the title [NotationV0] feat: notation workload identity [NotationV0] feat: azure-kv plugin workload identity support May 6, 2024
shizhMSFT
shizhMSFT approved these changes May 7, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

@shizhMSFT
Copy link

@JeyJeyGao can you fix the check?

@JeyJeyGao
Copy link
Collaborator Author

@JeyJeyGao can you fix the check?

Passed now.

JeyJeyGao added 2 commits May 8, 2024 15:38
@JeyJeyGao
fix: bump update to version 0.240.0
e744ade 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'refs/remotes/origin/feat/notation_workl…
3e986a2 
…oad_identity' into feat/notation_workload_identity
@JeyJeyGao JeyJeyGao enabled auto-merge (squash) May 8, 2024 07:55
@JeyJeyGao
fix: update comment
57e21da 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao merged commit a160844 into microsoft:master May 8, 2024
11 checks passed
@JeyJeyGao JeyJeyGao deleted the feat/notation_workload_identity branch August 13, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriiBobreshev DmitriiBobreshev DmitriiBobreshev approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@kirill-ivlev kirill-ivlev Awaiting requested review from kirill-ivlev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeyJeyGao @shizhMSFT @DmitriiBobreshev