Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask NpmAuth Task Secret #19995

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Mask NpmAuth Task Secret #19995

merged 5 commits into from
Jun 13, 2024

Conversation

tintse-thxsky-MSFT
Copy link
Contributor

@tintse-thxsky-MSFT tintse-thxsky-MSFT commented Jun 12, 2024

Task name: NpmAuthenticateV0

Description: mask the secret/pat

Documentation changes required: N

Added unit tests: (Y/N) N

Attached related issue: Rather not attack internal org's link

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@tintse-thxsky-MSFT tintse-thxsky-MSFT changed the title mask npm registry auth Mask Npm Task Secret Jun 13, 2024
@tintse-thxsky-MSFT tintse-thxsky-MSFT changed the title Mask Npm Task Secret Mask NpmAuth Task Secret Jun 13, 2024
- restored package-lock.json file
- restored package-lock.json file
@tintse-thxsky-MSFT tintse-thxsky-MSFT marked this pull request as ready for review June 13, 2024 17:25
@tintse-thxsky-MSFT tintse-thxsky-MSFT requested a review from a team as a code owner June 13, 2024 17:25
@embetten
Copy link
Contributor

LGTM

@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit 4f87803 into master Jun 13, 2024
11 checks passed
@tintse-thxsky-MSFT tintse-thxsky-MSFT deleted the users/tintse/mask_secret branch June 21, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants