Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DockerComposeV1 task and refactoring DockerComposeV0 #20085

Merged
merged 30 commits into from
Jul 1, 2024

Conversation

ivanduplenskikh
Copy link
Contributor

@ivanduplenskikh ivanduplenskikh commented Jun 28, 2024

Task name: DockerComposeV0, DockerComposeV1

Description: This PR adds DockerComposeV1 and remove the feature flag USE_DOCKER_COMPOSE_V2_COMPATIBLE_MODE from DockerComposeV0

Documentation changes required: N

Added unit tests: N

Attached related issue: AB#2168817

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@ivanduplenskikh ivanduplenskikh requested review from manolerazvan and a team as code owners June 28, 2024 15:02
Copy link

azure-boards bot commented Jul 1, 2024

✅ Successfully linked to Azure Boards work item(s):

@ivanduplenskikh ivanduplenskikh merged commit d8e6a2e into master Jul 1, 2024
11 checks passed
@ivanduplenskikh ivanduplenskikh deleted the users/v-ivandu/add-DockerComposeV1-task branch July 1, 2024 14:46
@sandywangkpmg
Copy link

sandywangkpmg commented Jul 5, 2024

@ivanduplenskikh I don't see any docs change here, and the official website is not yet updated https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/docker-compose-v0?view=azure-pipelines.
image

Without the update on official document, this release of DockerComposeV1 is not complete! And how the end users migrate to V1 task without a document to follow?

@peruzzof
Copy link

peruzzof commented Jul 5, 2024

Is There an official date to remove the @0 version?

@sandywangkpmg
Copy link

Is There an official date to remove the @0 version?

Reading from the commited code, it's 24th July.

@benoityip
Copy link

Screenshot 2024-07-21 173525

I am using DockerCompose@1 and have the above error. I have already removed "Version" in my docker compose file. This error is for the generated docker compose file

@vinayprakash893
Copy link

Hi @ivanduplenskikh , @sandywangkpmg @peruzzof @benoityip @DergachevE ,

Any update on the official, Docker-compose v2(DockerCompose@1) version in azure devops..?

@ivanduplenskikh
Copy link
Contributor Author

@vinayprakash893, @sandywangkpmg, the official DockerCompose@1 task documentation can be found at this link DockerCompose@1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants