Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NpmV1] Replace sync execution with async #20119

Merged
merged 2 commits into from
Jul 8, 2024
Merged

[NpmV1] Replace sync execution with async #20119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3ac8f
[NpmV1] Replace sync execution with async
DmitriiBobreshev Jul 5, 2024
4a2b00a
Merge branch 'master' into users/v-bobreshevd/npm-async-logs
DmitriiBobreshev Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/NpmV1/npmcustom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export async function run(packagingLocation: PackagingLocation, command?: string
const npm = new NpmToolRunner(workingDir, npmrc, overrideNpmrc);
npm.line(command || tl.getInput(NpmTaskInput.CustomCommand, true));

npm.execSync();
await npm.exec();

tl.rmRF(npmrc);
tl.rmRF(util.getTempPath());
Expand Down
2 changes: 1 addition & 1 deletion Tasks/NpmV1/npmpublish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function run(packagingLocation: PackagingLocation): Promise<void> {
const npm = new NpmToolRunner(workingDir, npmrc, true);
npm.line('publish');

npm.execSync();
await npm.exec();

tl.rmRF(npmrc);
tl.rmRF(util.getTempPath());
Expand Down
410 changes: 205 additions & 205 deletions Tasks/NpmV1/task.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Tasks/NpmV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 241,
"Minor": 242,
"Patch": 0
},
"runsOn": [
Expand Down
4 changes: 2 additions & 2 deletions _generated/NpmV1.versionmap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Default|1.241.0
Node20_229_1|1.241.1
Default|1.242.0
Node20_229_1|1.242.1
2 changes: 1 addition & 1 deletion _generated/NpmV1/npmcustom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export async function run(packagingLocation: PackagingLocation, command?: string
const npm = new NpmToolRunner(workingDir, npmrc, overrideNpmrc);
npm.line(command || tl.getInput(NpmTaskInput.CustomCommand, true));

npm.execSync();
await npm.exec();

tl.rmRF(npmrc);
tl.rmRF(util.getTempPath());
Expand Down
2 changes: 1 addition & 1 deletion _generated/NpmV1/npmpublish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function run(packagingLocation: PackagingLocation): Promise<void> {
const npm = new NpmToolRunner(workingDir, npmrc, true);
npm.line('publish');

npm.execSync();
await npm.exec();

tl.rmRF(npmrc);
tl.rmRF(util.getTempPath());
Expand Down
6 changes: 3 additions & 3 deletions _generated/NpmV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 241,
"Minor": 242,
"Patch": 0
},
"runsOn": [
Expand Down Expand Up @@ -208,7 +208,7 @@
"UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth."
},
"_buildConfigMapping": {
"Default": "1.241.0",
"Node20_229_1": "1.241.1"
"Default": "1.242.0",
"Node20_229_1": "1.242.1"
}
}
6 changes: 3 additions & 3 deletions _generated/NpmV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 241,
"Minor": 242,
"Patch": 0
},
"runsOn": [
Expand Down Expand Up @@ -208,7 +208,7 @@
"UnsupportedServiceConnectionAuth": "ms-resource:loc.messages.UnsupportedServiceConnectionAuth"
},
"_buildConfigMapping": {
"Default": "1.241.0",
"Node20_229_1": "1.241.1"
"Default": "1.242.0",
"Node20_229_1": "1.242.1"
}
}
2 changes: 1 addition & 1 deletion _generated/NpmV1_Node20/npmcustom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export async function run(packagingLocation: PackagingLocation, command?: string
const npm = new NpmToolRunner(workingDir, npmrc, overrideNpmrc);
npm.line(command || tl.getInput(NpmTaskInput.CustomCommand, true));

npm.execSync();
await npm.exec();

tl.rmRF(npmrc);
tl.rmRF(util.getTempPath());
Expand Down
2 changes: 1 addition & 1 deletion _generated/NpmV1_Node20/npmpublish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function run(packagingLocation: PackagingLocation): Promise<void> {
const npm = new NpmToolRunner(workingDir, npmrc, true);
npm.line('publish');

npm.execSync();
await npm.exec();

tl.rmRF(npmrc);
tl.rmRF(util.getTempPath());
Expand Down
6 changes: 3 additions & 3 deletions _generated/NpmV1_Node20/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 241,
"Minor": 242,
"Patch": 1
},
"runsOn": [
Expand Down Expand Up @@ -212,7 +212,7 @@
"UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth."
},
"_buildConfigMapping": {
"Default": "1.241.0",
"Node20_229_1": "1.241.1"
"Default": "1.242.0",
"Node20_229_1": "1.242.1"
}
}
6 changes: 3 additions & 3 deletions _generated/NpmV1_Node20/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 241,
"Minor": 242,
"Patch": 1
},
"runsOn": [
Expand Down Expand Up @@ -212,7 +212,7 @@
"UnsupportedServiceConnectionAuth": "ms-resource:loc.messages.UnsupportedServiceConnectionAuth"
},
"_buildConfigMapping": {
"Default": "1.241.0",
"Node20_229_1": "1.241.1"
"Default": "1.242.0",
"Node20_229_1": "1.242.1"
}
}
Loading