Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureFunctionAppV2 Changes for Flex and fix race condition. #20191

Merged
merged 20 commits into from
Jul 30, 2024

Conversation

FinVamp1
Copy link
Contributor

Task name: AzureFunctionAppv2

Description: Added Support for Flex Consumption and resolved race condition on Run From Package App Setting.

Documentation changes required: (Y) This adds support for a New Sku and has a new Parameter.

Added unit tests: (N)

Attached related issue: (Y) #19909

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@FinVamp1 FinVamp1 requested review from patelchandni, manolerazvan and a team as code owners July 22, 2024 22:26
@FinVamp1
Copy link
Contributor Author

azp /rerun

@FinVamp1
Copy link
Contributor Author

azp /run

Copy link
Contributor

@manolerazvan manolerazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the task version

@e-karlsson
Copy link

Hi @FinVamp1 ! I stumbled across this PR after troubleshooting deployment of a Function app to new Flex Consumption. I am aware that Flex Consumption is in preview mode and the documentation says "Continuous deployment using Azure DevOps Tasks (AzureFunctionApp@2) is not supported". So what was this PR for?

When I run it, I see the following in the logs:

Got service connection details for Azure App Service:'<func app name>'
The Deployment Type option does not apply for Flex Consumption.
Successfully updated App Service configuration details
Successfully added release annotation to the Application Insight : <func app name>
App Service Application URL: https://<func app name>.azurewebsites.net/
Finishing: Azure Function App Deploy: <func app name>

But the Function app did not have any functions. I cannot find any documentation how to use it also, do you have it somewhere?

@FinVamp1
Copy link
Contributor Author

Hello, @e-karlsson the way the task is designed is that the appType should be set to functionAppLinux and then the task will detect that the App is running on Flex Consumption and deploy to app using the Flex Consumption deployment endpoint. The aim of this PR was to add support for this while Flex Consumption is on Preview. Thanks for pointing out that the docs have not been updated and we will work on this soon. If you can share your app name or full deployment logs to me using finbarr AT microsoft.com and I will look at this for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants