Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating latest openssl version #20451

Merged
merged 9 commits into from
Sep 24, 2024

Conversation

Deekshitha981
Copy link
Collaborator

@Deekshitha981 Deekshitha981 commented Sep 23, 2024

Task name:

Description: Currently used openssl version 1.0.1 is deprecated and cx reported vulnerability issues with the version. So, updating the package with latest openssl version 3.3.1

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@Deekshitha981
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Deekshitha981 Deekshitha981 merged commit 80aaed9 into master Sep 24, 2024
11 checks passed
@azizabah
Copy link

azizabah commented Oct 1, 2024

@Deekshitha981 - I think this change introduced a bug.
When I run my Azure file copy task yesterday it pulled logged out this info

"D:\a\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\4.245.3\ps_modules\VstsAzureHelpers_\openssl\openssl.exe" pkcs12 -export -in "D:\a\_temp\clientcertificate.pem" -out "D:\a\_temp\clientcertificate.pfx" -password file:"D:\a\_temp\clientcertificatepassword.txt"
Connect-AzAccount 

Note the 4.245.3

On my failed uses of the task today, they are using this

"D:\a\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\4.246.1\ps_modules\VstsAzureHelpers_\openssl\openssl.exe" pkcs12 -export -in "D:\a\_temp\clientcertificate.pem" -out "D:\a\_temp\clientcertificate.pfx" -password file:"D:\a\_temp\clientcertificatepassword.txt"
Connect-AzAccount

and are generating these logs:

WARNING: can't open config file: D:\a\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\4.246.1\ps_modules\VstsAzureHelpers_\openssl\openssl.cnf
##[warning]The output of cmdlet New-AzStorageContext may compromise security by showing the following secrets: TableStorageAccount.Credentials.Key, ConnectionString. Learn more at https://go.microsoft.com/fwlink/?linkid=2258844
##[warning]The output of cmdlet Get-AzStorageContainer may compromise security by showing the following secrets: Context.TableStorageAccount.Credentials.Key, Context.ConnectionString. Learn more at https://go.microsoft.com/fwlink/?linkid=2258844
"D:\a\_tasks\AzureFileCopy_eb72cb01-a7e5-427b-a8a1-1b31ccac8a43\4.246.1\ps_modules\VstsAzureHelpers_\openssl\openssl.exe" pkcs12 -export -in D:\a\_temp\clientcertificate.pem -out D:\a\_temp\clientcertificate.pfx -password file:"D:\a\_temp\clientcertificatepassword.txt"
 & "AzCopy\AzCopy.exe" login --service-principal --application-id "***" --certificate-path "D:\a\_temp\clientcertificate.pfx" --tenant-id="dbbfc1e7-994f-49c6-bdb2-a1092a0da494" --aad-endpoint "[https://login.windows.net/"](https://login.windows.net/%22)
INFO: If you set an environment variable by using the command line, that variable will be readable in your command line history. Consider clearing variables that contain credentials from your command line history.  To keep variables from appearing in your history, you can use a script to prompt the user for their credentials, and to set the environment variable.

Failed to perform login command: 
pkcs12: unknown digest algorithm: 2.16.840.1.101.3.4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants