NpmAuth Regression Bugfix #20453
Merged
NpmAuth Regression Bugfix #20453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embetten
approved these changes
Sep 23, 2024
|
@AlexVTor This appears to break at least one case where multiple registries are in an .npmrc file and we later want to publish to the non-default registry. I'll write up a bug in the morning, but behavior worked in 0.238.2 and does not in 0.246.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: NpmAuthenticateV0
Description: v 0.244.0 shipped with a breaking bug for some users, where the npmauth task completed successfully but didn't authenticate a registry (npm installs/publishes/other operations fail). This fixes a bug that was shipped with that version of the task
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) #20361
Checklist: