Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --includeLocalPackagesBuildConfig option to make.js + LocalPackages BuildConfig #20463

Merged
merged 21 commits into from
Sep 26, 2024

Conversation

merlynomsft
Copy link
Contributor

@merlynomsft merlynomsft commented Sep 25, 2024

Task name: N/A

Description: No substantial functional changes are applied by default in this PR. This change adds an option to generate a new build configuration (LocalPackage) that consume internal dependencies using file: references in package.json. If enabled, the LocalPackage configuration uses a shared version across tasks which is managed by BuildConfigGen.

Note: using --includeLocalPackagesBuildConfig is dependent on task-lib and tasks-common being present in the repo, which is not included in this PR

Minor updates:

  • Updated wording for out-of-date generated file check to reference 'node make.js'
  • Added --skipToTask [task] and --skipPrebuildSteps to make.js to aid in debugging

Documentation changes required: Added locakpackages_buildconfig.md

Added unit tests: Tested via output generation. PR checks tested here:

Attached related issue: AB#2121133

Checklist:

  • [ (n/a) ] Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@merlynomsft merlynomsft changed the title update Add --includeLocalPackagesBuildConfig option to make.js Sep 26, 2024
@merlynomsft merlynomsft changed the title Add --includeLocalPackagesBuildConfig option to make.js Add --includeLocalPackagesBuildConfig option to make.js + Local Sep 26, 2024
@merlynomsft merlynomsft changed the title Add --includeLocalPackagesBuildConfig option to make.js + Local Add --includeLocalPackagesBuildConfig option to make.js + LocalPackages BuildConfig Sep 26, 2024
@merlynomsft merlynomsft marked this pull request as ready for review September 26, 2024 05:08
@merlynomsft merlynomsft requested a review from a team as a code owner September 26, 2024 05:08
@merlynomsft merlynomsft merged commit 4defd17 into master Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants