LocalPackages config to _generated_local (no CI needed for gen code) #20504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to BuildConfigGen to support unverified writes to _generated_local Fixes for globalversion.txt updates
DergachevE
approved these changes
Oct 3, 2024
merlynomsft
changed the title
DergachevE
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: N/A
Description:
No change to existing builds configs (e.g. Node20). _generate_local only applies to LocalPackage config
Updates to BuildConfigGen and make.js support _generated_local
Fixes for globalversion.txt updates
Documentation changes required: docs/localpackages_buildconfig.md
Testing: Inline asserts (exceptions) + #20505
Attached related issue: (Y/N) N/A
Checklist:
AB#2121133