Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for version collisions when generating global version #20544

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

merlynomsft
Copy link
Contributor

@merlynomsft merlynomsft commented Oct 15, 2024

Task name: N/A

Description:

  1. When adding global version, task versions initalized to major version 0 instead of major version
  2. To avoid collisions, when determining global version, we need to look at versions across all tasks, not just the one being built

Documentation changes required: N

Added unit tests: Inline integrity checks

Attached related issue: AB#2121133

Checklist:

  • [ (n/a) ] Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

1. When adding global version, task versions initalized to major version 0 instead of major version
2. To avoid collisions, when determining global version, we need to look at versions across all tasks, not just the one being built
@merlynomsft merlynomsft marked this pull request as ready for review October 15, 2024 01:11
@merlynomsft merlynomsft merged commit d10c07d into master Oct 15, 2024
11 checks passed
@merlynomsft merlynomsft deleted the users/merlynop/localpkgsfixes branch October 15, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants