Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message for 'Script Location' task AzureCLIV2 #20615

Closed
wants to merge 9 commits into from

Conversation

yilas
Copy link

@yilas yilas commented Nov 4, 2024

Added missing space in the error message for 'Script Location' input, changing "Value can either be'inlineScript' or 'scriptPath'" to "Value can either be 'inlineScript' or 'scriptPath'" for improved readability.

Task name: AzureCLIV2

Description: It seems that there is a missing space between "be" and "'inlineScript'," which would improve readability (see the issue #20616)

Documentation changes required: (Y/N)

Added unit tests: N

Attached related issue: Y

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Added missing space in the error message for 'Script Location' input, changing 
"Value can either be'inlineScript' or 'scriptPath'" to "Value can either be 'inlineScript' or 'scriptPath'"
for improved readability.
@yilas yilas requested review from manolerazvan and a team as code owners November 4, 2024 12:53
@yilas yilas marked this pull request as draft November 4, 2024 13:16
@yilas
Copy link
Author

yilas commented Nov 4, 2024

@microsoft-github-policy-service agree

@v-schhabra v-schhabra marked this pull request as ready for review November 4, 2024 13:28
@v-schhabra
Copy link
Contributor

@yilas Please check these instructions and update the patch to 0 in task.json file.
https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/taskversionbumping.md

@yilas
Copy link
Author

yilas commented Nov 4, 2024

@yilas Please check these instructions and update the patch to 0 in task.json file. https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/taskversionbumping.md

Done... Apologies for not having made this change previously.

Copy link
Contributor

@v-schhabra v-schhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yilas I observed that some generated files are not updated. Ig you havent run the build and some other commands.
These are the list of commands which you need to run after making the code changes.

Step 1: run "npm i"
Step 2: Build: node make.js build --task AzureFileCopyV4 //Replace the taskname here
node make.js test --task AzurePowerShellV4
Step 3: Install tfx: // one time
npm install -g tfx-cli
Step 4: Login: tfx login
Service URL : https://v-jkaggrri.visualstudio.com/DefaultCollection // Replace with your org URL
PAT : with full scope
Step 5: Upload: tfx build tasks upload --task-path C:\AzurePipelineTask\azure-pipelines-tasks_build\Tasks\AzureFileCopyV4
Step 6: Delete: // optional
tfx build tasks delete --task-id 1b2aec60-dc49-11e6-9b76-63056e018cac

@v-schhabra
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@yilas
Copy link
Author

yilas commented Nov 5, 2024

@yilas I observed that some generated files are not updated. Ig you havent run the build and some other commands. These are the list of commands which you need to run after making the code changes.

Step 1: run "npm i" Step 2: Build: node make.js build --task AzureFileCopyV4 //Replace the taskname here node make.js test --task AzurePowerShellV4 Step 3: Install tfx: // one time npm install -g tfx-cli Step 4: Login: tfx login Service URL : https://v-jkaggrri.visualstudio.com/DefaultCollection // Replace with your org URL PAT : with full scope Step 5: Upload: tfx build tasks upload --task-path C:\AzurePipelineTask\azure-pipelines-tasks_build\Tasks\AzureFileCopyV4 Step 6: Delete: // optional tfx build tasks delete --task-id 1b2aec60-dc49-11e6-9b76-63056e018cac

Done... Hope everything is OK 👌🏻

@v-schhabra
Copy link
Contributor

v-schhabra commented Nov 6, 2024

Hi @yilas
Could you please delete packagelock.json file as that is not needed here.

@yilas
Copy link
Author

yilas commented Nov 6, 2024

Hi @yilas Could you please delete packagelock.json file as that is not needed here.

Hi @v-schhabra,
package-lock.json removed

@v-schhabra
Copy link
Contributor

Could you try to run build command again becoz I could see package-lock.json file

@yilas
Copy link
Author

yilas commented Nov 7, 2024

Could you try to run build command again becoz I could see package-lock.json file

Hello @v-schhabra,
That’s strange because I ran the build command again (from this repository), and the file doesn’t seem to be present anymore.

@yilas ➜ /workspaces/azure-pipelines-tasks (patch-1) $ git status
Refresh index: 100% (20537/20537), done.
On branch patch-1
Your branch is up to date with 'origin/patch-1'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        package-lock.json

nothing added to commit but untracked files present (use "git add" to track)

@v-schhabra
Copy link
Contributor

v-schhabra commented Nov 8, 2024

I have created a new PR by incorporating the changes. #20637
Will close this PR.

@v-schhabra v-schhabra closed this Nov 11, 2024
@yilas yilas deleted the patch-1 branch November 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants