-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in error message for 'Script Location' task AzureCLIV2 #20615
Conversation
Added missing space in the error message for 'Script Location' input, changing "Value can either be'inlineScript' or 'scriptPath'" to "Value can either be 'inlineScript' or 'scriptPath'" for improved readability.
@microsoft-github-policy-service agree |
@yilas Please check these instructions and update the patch to 0 in task.json file. |
Done... Apologies for not having made this change previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yilas I observed that some generated files are not updated. Ig you havent run the build and some other commands.
These are the list of commands which you need to run after making the code changes.
Step 1: run "npm i"
Step 2: Build: node make.js build --task AzureFileCopyV4 //Replace the taskname here
node make.js test --task AzurePowerShellV4
Step 3: Install tfx: // one time
npm install -g tfx-cli
Step 4: Login: tfx login
Service URL : https://v-jkaggrri.visualstudio.com/DefaultCollection // Replace with your org URL
PAT : with full scope
Step 5: Upload: tfx build tasks upload --task-path C:\AzurePipelineTask\azure-pipelines-tasks_build\Tasks\AzureFileCopyV4
Step 6: Delete: // optional
tfx build tasks delete --task-id 1b2aec60-dc49-11e6-9b76-63056e018cac
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Done... Hope everything is OK 👌🏻 |
Hi @yilas |
Hi @v-schhabra, |
Could you try to run build command again becoz I could see package-lock.json file |
Hello @v-schhabra, @yilas ➜ /workspaces/azure-pipelines-tasks (patch-1) $ git status
Refresh index: 100% (20537/20537), done.
On branch patch-1
Your branch is up to date with 'origin/patch-1'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
package-lock.json
nothing added to commit but untracked files present (use "git add" to track) |
I have created a new PR by incorporating the changes. #20637 |
Added missing space in the error message for 'Script Location' input, changing "Value can either be'inlineScript' or 'scriptPath'" to "Value can either be 'inlineScript' or 'scriptPath'" for improved readability.
Task name: AzureCLIV2
Description: It seems that there is a missing space between "be" and "'inlineScript'," which would improve readability (see the issue #20616)
Documentation changes required: (Y/N)
Added unit tests: N
Attached related issue: Y
Checklist: