Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated ESRPv1 to V5 for code signing #20624

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

vinayakmsft
Copy link
Contributor

@vinayakmsft vinayakmsft commented Nov 6, 2024

Task name: PublishCodeCoverageV2

Description: We migrated the ESRP Code signing task from v1 to v5 according to the recent security updates. Earlier we were signing the binaries using ESRP V1 task. V1 is deprecated, now we need to sign with V5 task. This involved setting up the V5 task in the pipeline
Documentation changes required: (Y/N) no

Build pipeline - https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=29242799&view=results

Release pipeline to upload zip file - https://dev.azure.com/mseng/AzureDevOps/_releaseProgress?releaseId=21698389&_a=release-environment-logs&environmentId=212826930

New zip link - https://testmanagementstore.z13.web.core.windows.net/testmanagementcoverage/29242799/CoveragePublisher.zip

Testing:

image

WithBranchCoverage

image

Task logs

image
image

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@vinayakmsft vinayakmsft changed the title Migrated ESRPv1 to V5 for code siging Migrated ESRPv1 to V5 for code signing Nov 6, 2024
@virekumar
Copy link
Contributor

virekumar commented Nov 6, 2024

Can you share snapshot of logs showing version of task ?
Also you can deploy this version using tfx-cli on testmate accounts to see everything is working fine in prod.

Done addressed
Deployed it to private test org and verified its working fine - https://dev.azure.com/ForCjson/CCDemo/_build/results?buildId=1474&view=results

@virekumar virekumar assigned virekumar and unassigned virekumar Nov 6, 2024
@vinayakmsft vinayakmsft merged commit 615e37a into master Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants