Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SCP to CopyFilesOverSSH #2160

Merged
merged 2 commits into from
Jul 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"loc.friendlyName": "SCP",
"loc.friendlyName": "Copy Files Over SSH",
"loc.helpMarkDown": "[More Information](http://go.microsoft.com/fwlink/?LinkId=821894)",
"loc.description": "Copy files or build artifacts to a remote machine using SSH",
"loc.description": "Copy files or build artifacts to a remote machine over SSH",
"loc.instanceNameFormat": "Securely copy files to the remote machine",
"loc.group.displayName.advanced": "Advanced",
"loc.input.label.sshEndpoint": "SSH endpoint",
Expand Down
File renamed without changes.
Binary file added Tasks/CopyFilesOverSSH/icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions Tasks/SCP/icon.svg → Tasks/CopyFilesOverSSH/icon.svg
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes.
8 changes: 4 additions & 4 deletions Tasks/SCP/task.json → Tasks/CopyFilesOverSSH/task.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"id": "67cec91b-0351-4c2f-8465-d74b3d2a2d96",
"name": "SCP",
"friendlyName": "SCP",
"description": "Copy files or build artifacts to a remote machine using SSH",
"name": "CopyFilesOverSSH",
"friendlyName": "Copy Files Over SSH",
"description": "Copy files or build artifacts to a remote machine over SSH",
"helpMarkDown": "[More Information](http://go.microsoft.com/fwlink/?LinkId=821894)",
"category": "Deploy",
"visibility": [
Expand Down Expand Up @@ -88,7 +88,7 @@
],
"execution": {
"Node": {
"target": "scp.js",
"target": "copyfilesoverssh.js",
"argumentFormat": ""
}
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "67cec91b-0351-4c2f-8465-d74b3d2a2d96",
"name": "SCP",
"name": "CopyFilesOverSSH",
"friendlyName": "ms-resource:loc.friendlyName",
"description": "ms-resource:loc.description",
"helpMarkDown": "ms-resource:loc.helpMarkDown",
Expand Down Expand Up @@ -87,7 +87,7 @@
],
"execution": {
"Node": {
"target": "scp.js",
"target": "copyfilesoverssh.js",
"argumentFormat": ""
}
},
Expand Down
Binary file removed Tasks/SCP/icon.png
Binary file not shown.
20 changes: 10 additions & 10 deletions Tests/L0/SCP/_suite.ts → Tests/L0/CopyFilesOverSSH/_suite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function setResponseFile(name: string) {
process.env['MOCK_RESPONSES'] = path.join(__dirname, name);
}

describe('SCP Suite', function() {
describe('CopyFilesOverSSH Suite', function() {
this.timeout(20000);

before((done) => {
Expand All @@ -23,7 +23,7 @@ describe('SCP Suite', function() {
it('Fails for missing endpoint', (done) => {
setResponseFile('responseEndpoint.json');

var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);

tr.run()
.then(() => {
Expand All @@ -40,7 +40,7 @@ describe('SCP Suite', function() {
})
it('Fails for invalid private key', (done) => {
setResponseFile('responseEndpoint.json');
var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDInvalidKey');
tr.setInput('sourceFolder', '/user/build');
tr.setInput('contents', '**');
Expand All @@ -62,7 +62,7 @@ describe('SCP Suite', function() {
})
it('Fails when user name is not provided in the endpoint', (done) => {
setResponseFile('responseEndpoint.json');
var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDUserNameNotSet');
tr.setInput('contents', '**');
tr.setInput('targetFolder', '/home/mg');
Expand All @@ -82,7 +82,7 @@ describe('SCP Suite', function() {
})
it('Empty password/passphrase is valid in the endpoint', (done) => {
setResponseFile('responseEndpoint.json');
var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDPasswordNotSet');

tr.run()
Expand All @@ -97,7 +97,7 @@ describe('SCP Suite', function() {
})
it('Fails when host is not provided in the endpoint', (done) => {
setResponseFile('responseEndpoint.json');
var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDHostNotSet');

tr.run()
Expand All @@ -115,7 +115,7 @@ describe('SCP Suite', function() {
})
it('When port is not provided in the endpoint, 22 is used as default port number', (done) => {
setResponseFile('responseEndpoint.json');
var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDPortNotSet');

tr.run()
Expand All @@ -130,7 +130,7 @@ describe('SCP Suite', function() {
})
it('Fails when connection cannot be made with given details', (done) => {
setResponseFile('responseEndpoint.json');
var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDValidKey');
tr.setInput('sourceFolder', '/user/build');
tr.setInput('contents', '**');
Expand All @@ -152,7 +152,7 @@ describe('SCP Suite', function() {
it('Fails for missing target folder', (done) => {
setResponseFile('responseEndpoint.json');

var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDValidKey');
tr.setInput('sourceFolder', '/user/build');
tr.setInput('contents', '**');
Expand All @@ -171,7 +171,7 @@ describe('SCP Suite', function() {
it('Fails for missing contents', (done) => {
setResponseFile('responseEndpoint.json');

var tr = new trm.TaskRunner('SCP', true, true);
var tr = new trm.TaskRunner('CopyFilesOverSSH', true, true);
tr.setInput('sshEndpoint', 'IDValidKey');
tr.setInput('targetFolder', '/home/user');

Expand Down
2 changes: 1 addition & 1 deletion common.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"dest": "Common"
}
],
"SCP": [
"CopyFilesOverSSH": [
{
"module": "ssh-common",
"dest": "node_modules"
Expand Down