FtpUpload: rejectUnauthorized option #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "label": "Reject unauthorized SSL certificates", | ||
| "defaultValue": "true", | ||
| "required": true, | ||
| "helpMarkDown": "If selected, when connecting in secure mode with ftps://, the ftp server certificate is verified with several well known root certificate authorities (e.g. VeriSign). This option protects against invalid server authentication certificates which may be expired or revoked (e.g. if they were compromized). Disabling this option should be done with care, but is necessary if using self-signed certificates.", |
There was a problem hiding this comment.
"the ftp server certificate" → "the FTP server certificate"
"VeriSign" → "Verisign"
"compromized" → "compromised"
|
Looks good. I left 1 comment regarding text. Thanks for adding the test! |
jasholl
force-pushed
the
users/jasholl/ftpsSelfSigned
branch
from
db38f27 to
3509a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option gives users a path to use self signed certificates; the default is checked, so users would need to uncheck this option to lower security.
