Users allendm bugfix taefkey #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allendm/bugfix/taefkey
|
Can we add UT for this function. Rest looks good. |
| # ensure the registry is set otherwise you need to launch VSIDE | ||
| SetRegistryKeyForParallel $vsTestVersion | ||
| $devenvExe = [io.path]::Combine("$env:VS140COMNTools", "..", "IDE", "devenv.exe"); | ||
| $devenvVersion = [System.Diagnostics.FileVersionInfo]::GetVersionInfo($devenvExe); |
There was a problem hiding this comment.
can this throw File access exception? if my build agent is not running as admin?
There was a problem hiding this comment.
no.. can only throw FNF which should never occur
|
UTs for dev15+ added in prev PR this one is just to verify with U3+. This is verified manually |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from vs2015u3 onwards dont set the taef regkey for run in parallel