Strip quotes from nuget.exe path #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,7 +141,11 @@ function locateTool(tool: string, opts?: LocateOptions) { | |||
|
|
|||
| export function locateNuGetExe(userNuGetExePath: string): string { | |||
| if (userNuGetExePath) { | |||
| tl.debug(`using user-supplied NuGet path ${userNuGetExePath}`) | |||
| if (os.platform() === "win32") { | |||
There was a problem hiding this comment.
I think this is likely fine in your case. We discussed for lib and the reason we didn't do it there is double quote is valid in OSX and Linux in a dir name. So we can't blindly do it in a base lib.
There was a problem hiding this comment.
yep, this is literally just to resolve that one break and even then only on windows.
jmyersmsft
force-pushed
the
users/jmyers/stripQuotes
branch
from
c0ab22c to
d993a2a
Compare
|
@prashkan90 Can you take a look at this since you were asking about the bug before? |
|
@jmyersmsft Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.