Detect NuGet version and adjust behavior by per-version quirks #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be aware we forked for 105 which is RC2 and RTM. So port if you need in Dev15 |
|
@bryanmacfarlane will do. |
|
|
||
| function versionIsInRange(version: VersionInfoVersion, range: VersionRange): boolean { | ||
| const beginComparison = VersionInfoVersion.compare(version, range.begin); | ||
| const endComparison = VersionInfoVersion.compare(range.end, version); |
There was a problem hiding this comment.
swap arguments and use < below
|
I will do a tslint pass immediately after this PR |
|
I've added the following commits with PR feedback (the |
| } finally { | ||
| if (typeof file === "string") { | ||
| // we opened the file, so we're responsible for closing it | ||
| await readableFile.closeAsync(); |
There was a problem hiding this comment.
Add guard for readable file not being null?
if (typeof file === "string" && readableFile) {....}
|
|
(with comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.