Added Checkstyle integration to Maven. #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ import tl = require('vsts-task-lib/task'); | |||
| */ | |||
| export abstract class BaseTool implements IAnalysisTool { | |||
|
|
|||
| constructor(private toolName: string, protected buildOutput: BuildOutput, private uiInputName: string) { | |||
| constructor(protected toolName: string, protected buildOutput: BuildOutput, private uiInputName: string) { | |||
There was a problem hiding this comment.
Changed to allow subclasses to access this field.
HSAR
force-pushed
the
users/sschen/javatools
branch
from
15ac4ba to
a90a205
Compare
| @@ -8,9 +8,7 @@ import util = require('util'); | |||
| import {ToolRunner} from 'vsts-task-lib/toolrunner'; | |||
| import tl = require('vsts-task-lib/task'); | |||
|
|
|||
| import {ModuleAnalysis} from './moduleanalysis'; | |||
There was a problem hiding this comment.
Removing unused imports.
| return toolRunner; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I believe you haven't bumped the gradle task version.
There was a problem hiding this comment.
While there is no real cost to doing so, there is also no functional change to the Gradle task in this PR.
There was a problem hiding this comment.
Accepted - there may be new bugs that come up with this version.
|
LGTM |
HSAR
force-pushed
the
users/sschen/javatools
branch
from
a9380c0 to
9a3df29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.