Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven CC Report enabling #2623

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Conversation

nigurr
Copy link

@nigurr nigurr commented Sep 22, 2016

  • Fixed issue when Maven project contains both plugin management and plugins, append CC reporting to plugins instead of plugin management
  • UTs are added
  • Manual testing done

@allendm-msft
Copy link
Member

Seems fine. Wait on Yang to signoff

@yacaovsnc
Copy link
Member

yacaovsnc commented Sep 27, 2016

In general it looks good to me. I am not sure if you need to modify <pluginsManagement> section at all. However I also don't know all the scenarios, so if you think it's necessary, that probably doesn't hurt anyway.

@nigurr
Copy link
Author

nigurr commented Sep 28, 2016

@yacaovsnc, we have few scenarios where it's required :)

@nigurr nigurr merged commit 6456ffa into master Sep 28, 2016
@nigurr nigurr deleted the users/nigurr/FixMavenPluginHandling branch April 10, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants