Users/madhurig/xamarinios #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacaovsnc
reviewed
Oct 5, 2016
| await nugetRunner.exec(); | ||
|
|
||
| //Process working directory | ||
| var cwd = cwd || tl.getVariable('build.sourceDirectory') || tl.getVariable('build.sourcesDirectory'); |
There was a problem hiding this comment.
Probably can remove check for build.sourceDirectory? It's not defined in: https://www.visualstudio.com/en-us/docs/build/define/variables
There was a problem hiding this comment.
Yes it was there for the very old agent, I want to basically remove build.sourcesDirectory since the task might be running in a release definition too. But will do that when porting tests to new framework.
|
Looks good. |
madhurig
added a commit
that referenced
this pull request
Oct 5, 2016
* Update Xamarin iOS to common signing module and new vsts-task-lib * enable passing in keychain to xbuild for signing with certs * L0 tests for code signing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Xamarin iOS to use common code signing module, fix issues with not being able to use files for code signing