fix issue with not being able to find .dSYM files #2831
Conversation
| @@ -229,7 +229,10 @@ var submitToTestCloud = function (index) { | |||
| // For an iOS .ipa app, look for an accompanying dSYM file | |||
| if (dsym && path.extname(appFiles[index]) == '.ipa') { | |||
| // Find dSYM files matching the specified pattern | |||
| var alldsymFiles = tl.find(path.dirname(appFiles[index])); | |||
| // Check in one folder up since IPAs are now generated under a timestamped folder | |||
| var ipaFolder = path.dirname(path.dirname(appFiles[index])); | |||
There was a problem hiding this comment.
Will this cause any back compat issue?
There was a problem hiding this comment.
Will you be able to unit test this code by mocking path.dirname?
There was a problem hiding this comment.
@yacaovsnc: It shouldn't cause any compat issue since we will just be looking for .dSYM files one level up. Since the Xamarin support for Xcode 7 the IPAs are generated in a folder under the outDir where as the .dSYM file is under the outDir. So the task hasn't been finding the .dSYM files.
There was a problem hiding this comment.
@jpricketMSFT: To mock path.dirname, we have to create a dirname method in the task-lib. I will check if the new L0 framework allows a simpler way to mock this.
| @@ -229,7 +229,10 @@ var submitToTestCloud = function (index) { | |||
| // For an iOS .ipa app, look for an accompanying dSYM file | |||
| if (dsym && path.extname(appFiles[index]) == '.ipa') { | |||
| // Find dSYM files matching the specified pattern | |||
| var alldsymFiles = tl.find(path.dirname(appFiles[index])); | |||
| // Check in one folder up since IPAs are now generated under a timestamped folder | |||
| var ipaFolder = path.dirname(path.dirname(appFiles[index])); | |||
There was a problem hiding this comment.
Will you be able to unit test this code by mocking path.dirname?
#1983