-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the SonarQube msbuild tasks #3167
Conversation
"helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?LinkId=620063)", | ||
"category": "Build", | ||
"deprecated": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanmacfarlane - marking these as deprecated as discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good Bogdan
- Proposing to alter a bit the warning messages (to use the passive voice. Customers don't know who "we" are)
- SonarSource is in one word. That's pretty important, this is branding :)
@@ -2,6 +2,10 @@ Write-Verbose "Starting SonarQube PostBuild Step" | |||
|
|||
import-module "Microsoft.TeamFoundation.DistributedTask.Task.Common" | |||
|
|||
Write-Warning "We are transferring ownership of the SonarQube related build tasks to Sonar Source. Please replace these build tasks with the ones provided by Sonar Source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer. "The ownership of the SonarQube related build tasks is transferred to SonarSource". Also SonarSource is in one word. We'd need to have the link on their extension, also. Maybe we should involve Freddy / Tamas in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are aka.ms links in the messge. I'll update them once the final urls become
available.
@@ -2,6 +2,10 @@ Write-Verbose "Starting SonarQube PostBuild Step" | |||
|
|||
import-module "Microsoft.TeamFoundation.DistributedTask.Task.Common" | |||
|
|||
Write-Warning "We are transferring ownership of the SonarQube related build tasks to Sonar Source. Please replace these build tasks with the ones provided by Sonar Source. | |||
To do this, visit the marketplace to install the extension created by Sonar Source: https://aka.ms/sqextension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarSource (1 word)
@@ -27,6 +27,10 @@ Write-Verbose "includeFullReport = $includeFullReport" | |||
import-module "Microsoft.TeamFoundation.DistributedTask.Task.Common" | |||
import-module "Microsoft.TeamFoundation.DistributedTask.Task.Internal" | |||
|
|||
Write-Warning "We are transferring ownership of the SonarQube related build tasks to Sonar Source. Please replace these build tasks with the ones provided by Sonar Source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same message: "Ownership of the SonarQube for MSBuild tasks is transfered to SonarSource. Please replace these build tasks by the one brought by SonarSource's extension on the marketplace".
Save for "Sonar Source" => "SonarSource" comments left by @jmprieur, LGTM. |
LGTM |
So what happens now? When will the links sqdeprecated and sqtransfer links become active along with the new plugin in the marketplace? Are there additional items being released along with the 6.2 release of SonarQube? |
Hi @psyvision - SonarSource are still testing their extension. Once they publish their extension I'll update those URLs to point to it and to a blog post explaining more. SonarSource keep their backlog in the public, so have a look for yourself - https://jira.sonarsource.com/browse/TBSTFNP/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel There will be an aditional SonarQube task that wrapps the SonarQube Scanner, enabling scenarios such as scanning non-C# / non-Java payloads. |
Many thanks @bgavrilMS - I look at their JIRA occasionally to do with bug fixes (like Active Directory/SSO integration) but find it hard to navigate at times. |
* Deprecate the SonarQube msbuild tasks * Address PR issues
No description provided.