Users/arjgupta/iis mg update2 #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
reviewed
Jan 11, 2017
| var xmlSubstitutionUtility = require('webdeployment-common/xmlvariablesubstitutionutility.js'); | ||
| var xdtTransformationUtility = require('webdeployment-common/xdttransformationutility.js'); | ||
| var ft = require('webdeployment-common/fileTransformationsUtility.js'); | ||
| //var jsonSubstitutionUtility = require('webdeployment-common/jsonvariablesubstitutionutility.js'); |
There was a problem hiding this comment.
can u remove the comments ?
vincent1173
reviewed
Jan 11, 2017
| console.log(tl.loc("XDTTransformationsappliedsuccessfully")); | ||
| } | ||
| else { | ||
| throw new Error(tl.loc("CannotPerformXdtTransformationOnNonWindowsPlatform")); |
There was a problem hiding this comment.
error messages are missing in task.json
There was a problem hiding this comment.
have updated task.json accordingly
vincent1173
reviewed
Jan 11, 2017
| } | ||
|
|
||
| if(JSONFiles.length != 0) { | ||
| jsonSubstitutionUtility.jsonVariableSubstitution(folderPath, JSONFiles); |
There was a problem hiding this comment.
error messages are missing in task.json - > (inside jsonVariableSubstitution )
There was a problem hiding this comment.
have updated task.json accordingly
vincent1173
reviewed
Jan 11, 2017
| @@ -13,6 +13,11 @@ | |||
| "archiveName": "MSDeploy.zip", | |||
| "url": "https://vstsagenttools.blob.core.windows.net/tools/MSDeploy/3.6/MSDeploy.zip", | |||
| "dest": "./" | |||
| }, | |||
| { | |||
vincent1173
reviewed
Jan 11, 2017
| @@ -18,7 +19,11 @@ async function run() | |||
| var excludeFilesFromAppDataFlag: boolean = tl.getBoolInput('ExcludeFilesFromAppDataFlag', false); | |||
| var takeAppOfflineFlag: boolean = tl.getBoolInput('TakeAppOfflineFlag', false); | |||
| var additionalArguments: string = tl.getInput('AdditionalArguments', false); | |||
| var xmlTransformation: boolean = tl.getBoolInput('XmlTransformation', false); | |||
vincent1173
reviewed
Jan 11, 2017
| @@ -32,6 +37,13 @@ async function run() | |||
| webDeployPkg = availableWebPackages[0]; | |||
|
|
|||
| var isFolderBasedDeployment = await utility.isInputPkgIsFolder(webDeployPkg); | |||
|
|
|||
| if(JSONFiles.length != 0 || xmlTransformation || xmlVariableSubstitution) { | |||
vincent1173
reviewed
Jan 11, 2017
| @@ -4,6 +4,7 @@ import fs = require('fs'); | |||
|
|
|||
| var msDeploy = require('webdeployment-common/deployusingmsdeploy.js'); | |||
| var utility = require('webdeployment-common/utility.js'); | |||
| var ft = require('webdeployment-common/fileTransformationsUtility.js'); | |||
There was a problem hiding this comment.
can u name the variable like 'fileTransformationsUtility' ?
vincent1173
reviewed
Jan 11, 2017
| @@ -23,6 +23,11 @@ | |||
| "minimumAgentVersion": "1.102.0", | |||
There was a problem hiding this comment.
Agent version should be changed to 2.104.1.
kmkumaran
approved these changes
Jan 12, 2017
…osoft/vsts-tasks into users/arjgupta/iisMgUpdate2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.