Fixes Jenkins job search responses which doesn't have downstreamProjects #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ralfclaassens, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
ralfclaassens
changed the title
|
Thanks very much for the contribution, @ralfclaassens! Also for your work on the TFS Plugin for Jenkins. We'll get to that separate PR as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding: #3135
@davidstaheli: you were right. The main problem exists in the Jenkins TFS plugin. However, there is a small bug in the JenkinsQueueJob task as well. Therefore, it would be nice if you would review/merge this pull request.
In more details: the Job class currently assumes thisJob.search.parsedTaskBody.downstreamProjects as being an array. However, in the case of a MultibranchPipeline Job, Jenkins does not return 'downstreamProjects' as a JSON key at all (i.e. undefined). Of course, downstreamProjects.forEach() fails in this case. This fix / pull request will avoid this failure.