Remove dependency on strings.js 3.3.3 due to vulnerability report #7834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacaovsnc
approved these changes
Jul 25, 2018
|
Do you need to update task.json file? |
lkillgore
approved these changes
Jul 25, 2018
lkillgore
approved these changes
Jul 25, 2018
brcrista
approved these changes
Jul 25, 2018
|
Test failures are due to NPM timeouts, which seem flaky. Since I'm confident these failures aren't related to my PR, I'm merging in spite of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings.js v3.3.3 has a vulnerability reported against it, and while we don't use the affected methods it's easy enough to just remove this dependency.