Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloadTool function doesn't log progress, content-length or file size #27

Closed
4 tasks
hashtagchris opened this issue Jan 23, 2018 · 2 comments
Closed
4 tasks

Comments

@hashtagchris
Copy link

I had a tool installer task cache a truncated NuGet.exe (3 MB instead of 5 MB) in _tools. When I found the logs from the download there wasn't a lot of detail. See below.

  • If a Content-Length header is returned, downloadTool should log it.
  • During download, downloadTool should output progress.
  • After download, downloadTool should log the downloaded file size on disk.
  • If the Content-Length header is returned and the file size on disk doesn't match, downloadTool should probably retry or fail.
2018-01-10T19:46:36.3426146Z ##[section]Starting: Use NuGet 4.3.0
2018-01-10T19:46:36.3634872Z ==============================================================================
2018-01-10T19:46:36.3635036Z Task         : NuGet Tool Installer
2018-01-10T19:46:36.3635168Z Description  : Acquires a specific version of NuGet from the internet or the tools cache and adds it to the PATH. Use this step to change the version of NuGet used in the NuGet steps.
2018-01-10T19:46:36.3635300Z Version      : 0.1.5
2018-01-10T19:46:36.3635385Z Author       : Microsoft Corporation
2018-01-10T19:46:36.3635482Z Help         : [More Information](https://go.microsoft.com/fwlink/?linkid=852538)
2018-01-10T19:46:36.3635590Z ==============================================================================
2018-01-10T19:46:38.4983586Z Downloading: https://dist.nuget.org/win-x86-commandline/v4.3.0/nuget.exe
2018-01-10T19:46:38.9174057Z Caching tool: NuGet 4.3.0 x64
2018-01-10T19:46:39.5239777Z Using version: 4.3.0
2018-01-10T19:46:39.5242615Z Found tool in cache: NuGet 4.3.0 x64
2018-01-10T19:46:39.5243087Z Using tool path: D:\agents\pc\_work\_tool\NuGet\4.3.0\x64
2018-01-10T19:46:39.5246363Z Prepending PATH environment variable with directory: D:\agents\pc\_work\_tool\NuGet\4.3.0\x64
2018-01-10T19:46:39.5378912Z ##[section]Finishing: Use NuGet 4.3.0
@stephenmichaelf stephenmichaelf self-assigned this Jan 23, 2018
@stephenmichaelf
Copy link
Member

I will add this after my current set of tasks, thanks!

@ghost
Copy link

ghost commented Mar 31, 2022

PR with the change was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants