Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debug logs for downloadTool function #154

Merged
9 commits merged into from
Mar 31, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2022

This change adds more logging when we do downloadTool.

  1. If it exists, log content-length header
  2. Log size of file on disk
  3. Ensure content-length header and size on disk match

All tests passed successfully.

Based on request #27

@ghost ghost requested a review from mmrazik March 21, 2022 12:37
tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
@anatolybolshakov
Copy link
Contributor

@tatyana-kostromskaya could you please make sure that there is enough automatic tests coverage for this case? If not - please share manual tests results with use cases checked.

@ghost
Copy link
Author

ghost commented Mar 22, 2022

@anatolybolshakov I have added unit test for the new failure condition

tool.ts Outdated Show resolved Hide resolved
Tatyana Kostromskaya (Akvelon) added 2 commits March 22, 2022 16:50
tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
tool.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghost ghost merged commit 437d0e5 into master Mar 31, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants