Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to the Node 16 runtime #164

Merged
merged 14 commits into from
Jul 8, 2022

Conversation

AndreyIvanov42
Copy link
Contributor

@AndreyIvanov42 AndreyIvanov42 commented Jul 6, 2022

Task description

In order to migrate tasks to the Node16 execution handler, we have to update the azure-pipelines-tool-lib itself to support the Node16 runtime.

Changelog

  • Updated dev dependencies
  • Updated package-lock.json to version 2 to unlock the ability for deterministic and reproducible builds
  • Updated pipeline to use Node 16, MacOS 10.15, windows 2019
  • Updated pipeline to build an artifact in releases/2.x branch
  • Fixed one test

Testing

  • Changes have been tested on Linux, MacOS, Windows:
    by unit-tests
    manually as part of some task. Used tasks and cases are described here
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • I didn't find any breaking changes
  • There are no other concerns
  • I haven't discovered any new uncovered test/use cases

Note

The azure-pipelines-task-lib version should be changed to 4.0.0-preview when it's available on npm

@AndreyIvanov42 AndreyIvanov42 marked this pull request as ready for review July 6, 2022 18:17
@AndreyIvanov42
Copy link
Contributor Author

Migrated task

CopyFiles, UsePythonVersion, CMake

Environment used (OS/Agent)

Windows 10x64 / Agent with Node 16 handler, Ubuntu 16.04x64 / Agent with Node 16 handler, macOS 12 / Agent with Node 16 handler

Test cases

- task: CMake@1
  inputs:
    workingDirectory: 'src'
    cmakeArgs: -DCMAKE_SHELL=false -DTEST_ONE=one;two -DTEST_TWO=/one/two/three -DTEST_WIN_VARIABLE=test -DTEST_VARIABLE=test
    runInsideShell: false 
- task: CMake@1
  inputs:
    workingDirectory: 'src'
    cmakeArgs: -DCMAKE_SHELL=true -DTEST_ONE=one;two -DTEST_TWO=/one/two/three -DTEST_VARIABLE=$USER -DTEST_WIN_VARIABLE=%OS%
    runInsideShell: true
- task: UsePythonVersion@0
  inputs:
    versionSpec: 3.10.5
    disableDownloadFromRegistry: true
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents: *.js
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: false
    OverWrite: false
    flattenFolders: false
    preserveTimestamp: true
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents: *.js
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: false
    OverWrite: true
    flattenFolders: false
    preserveTimestamp: true
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents: *
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: true
    OverWrite: false
    flattenFolders: false
    preserveTimestamp: false
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents: **/bin/**
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: true
    OverWrite: false
    flattenFolders: true
    preserveTimestamp: false
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents: **
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: true
    OverWrite: false
    flattenFolders: true
    preserveTimestamp: false
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents: |
      *.css
      **/bin/**.css
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: true
    OverWrite: false
    flattenFolders: true
    preserveTimestamp: false
- task: CopyFiles@2
  inputs:
    SourceFolder: 'src/copy-files/source'
    Contents:  root-file1.js
    TargetFolder: 'src/copy-files/target'
    CleanTargetFolder: true
    OverWrite: false
    flattenFolders: false
    preserveTimestamp: true

@AndreyIvanov42 AndreyIvanov42 changed the title Users/v andivanov/release/2.x Migrating to the Node 16 runtime Jul 6, 2022
@alexander-smolyakov alexander-smolyakov requested a review from a team July 7, 2022 07:15
@AndreyIvanov42 AndreyIvanov42 merged commit ffbdfab into releases/2.x Jul 8, 2022
@AndreyIvanov42 AndreyIvanov42 mentioned this pull request Jul 12, 2022
@AndreyIvanov42 AndreyIvanov42 deleted the users/v-andivanov/release/2.x branch July 12, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants