This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix for tf.exe domain authentication #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue microsoft#246. In Windows domain credentials are not included by the argument builder
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
@dfrencham, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
I'm hitting this exact issue. Thanks for the fix! |
This was referenced Aug 10, 2017
|
Thanks @dfrencham for the submission. I had a look and tried it out. I'll merge this and then follow up with a unit test to ensure we don't regress this going forward. I expect it'll get into a release early next week. Thanks again! |
jeffyoung
pushed a commit
that referenced
this pull request
Aug 10, 2017
jeffyoung
pushed a commit
that referenced
this pull request
Aug 10, 2017
* Add unit test for #291 (ensuring domain is used with ArgumentBuilder) * Ensure we log an exception when 'Device Flow' fails
This was referenced Aug 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #246. On the Windows platform domain credentials are not included by the
argument builder.
This issue only affects credentials with a domain specified. If the user specifies a username in this format: domain\user - when retrieved by the credential manager, the domain portion is split and returned in CredentialInfo.domain. This affects the argumentBuilder, the domain is not included when passing the "login" property to tf.exe.
This issue causes authentication to fail. commandHelper.ProcessErrors assumes this is a local/server workspace issue and returns:
It appears you are using a Server workspace. Currently, TFVC support is limited to Local workspaces.A possible workaround may be to use TEE-CLC and pass credentials in user@domain format. TF.exe only accepts domain\user format.