Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Skip AAD internal filter when is already authenticated or token not issued by AAD#872

Merged
saragluna merged 2 commits intomasterfrom
feature/aad-filters-action-condition
May 14, 2020
Merged

Skip AAD internal filter when is already authenticated or token not issued by AAD#872
saragluna merged 2 commits intomasterfrom
feature/aad-filters-action-condition

Conversation

@saragluna
Copy link
Contributor

Summary

When AADAuthenticationFilter or AADAppRoleStatelessAuthenticationFilter is auto-configured it will take action on every bearer token. This PR will skip the processing when the current context is already authenticated or the token is not issued by Azure AD.

Issue Type

  • New Feature

Starter Names

  • active directory spring boot starter

Additional Information

@nikhilingole
Copy link

Hey @saragluna / @jialindai - Any updates on this, when would it be part of a release.
Thanks.

@saragluna saragluna merged commit 1041b83 into master May 14, 2020
@saragluna
Copy link
Contributor Author

@nikhilingole This will be out in our next release, which is two weeks later.

@nikhilingole
Copy link

Thanks @saragluna for the update and fixing the issue.

As a side comment - Shouldn't the response from the filter be 401/403 if the Token in invalid/expired etc instead of 5xx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants