Deliver multiple KeyVault support#880
Deliver multiple KeyVault support#880saragluna merged 11 commits intomicrosoft:masterfrom mnriem:keyvault-multiple-vaults
Conversation
saragluna
left a comment
There was a problem hiding this comment.
- We'd better also change the document to demonstrate how to use multiple KeyVault, and clarify the precedence of them when containing the same key.
- I'm not sure which pattern is better to organize the KeyVault properties:
- The pattern used in this PR,
<keyvault-name>.azure.keyvault.xxx, will keep the implementation neat. - The pattern like this
azure.keyvault.<keyvault-name>.xxxwill make the properties organized in one unified namespace.
...rc/main/java/com/microsoft/azure/keyvault/spring/KeyVaultEnvironmentPostProcessorHelper.java
Outdated
Show resolved
Hide resolved
|
When you say the document which one do you mean? On the order yes we need to clarify that the order of the .names attribute determines the order in which the respective KeyVaults are consulted. On the naming convention I opted for the key vault name at the beginning as it was easier/cleaner in the implementation to add it, but I have no preference. So if it needs to be changed just say the word. |
|
Sorry for not mentioning where to add them. A section describing the new feature added to the README.md will be enough. If the If we want to use the |
|
OK I will change it to use to the |
|
There're some unit tests failed. |
| When telemetry is enabled, an HTTP request will be sent to URL `https://dc.services.visualstudio.com/v2/track`. So please make sure it's not blocked by your firewall. | ||
| Find more information about Azure Service Privacy Statement, please check [Microsoft Online Services Privacy Statement](https://www.microsoft.com/en-us/privacystatement/OnlineServices/Default.aspx). | ||
|
|
||
| ## Multiple Key Vault support |
There was a problem hiding this comment.
What if the user also sets the azure.keyvault.uri, what's the order between them?
There was a problem hiding this comment.
The order would be dependent on the order in the file, but I feel we should caution a customer against doing that. If they opt for multiple key vaults they should only use it that way so the order is guaranteed. I will add this to the documentation.
…figuration if multiple key vaults are to be used
Summary
Delivers support for multiple keyvaults
Issue Type
Starter Names
Additional Information