Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing config check when submit job from azure node #2694

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Add missing config check when submit job from azure node #2694

merged 4 commits into from
Jan 22, 2019

Conversation

konjac
Copy link
Contributor

@konjac konjac commented Jan 22, 2019 •
edited
Loading

To address #2689 #2693
The configuration check message has been moved after clicking to run.

wezhang
wezhang approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@wezhang wezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kun! LGTM! Shipit!

@konjac konjac merged commit 66d962d into microsoft:develop Jan 22, 2019
@wezhang wezhang added this to the v3.18.0 milestone Jan 23, 2019
andxu pushed a commit to andxu/azure-tools-for-java that referenced this pull request Mar 24, 2020
@konjac
Add missing config check when submit job from azure node (microsoft#2694
d61c49d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezhang wezhang wezhang approved these changes

@jingyanjingyan jingyanjingyan Awaiting requested review from jingyanjingyan

@v-jiche v-jiche Awaiting requested review from v-jiche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@konjac @wezhang