Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1882757] Conflicting component name 'RunManager' #5908

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

wangmingliang-ms
Copy link
Collaborator

@wangmingliang-ms wangmingliang-ms commented Oct 8, 2021

@wangmingliang-ms wangmingliang-ms requested a review from andxu October 8, 2021 02:47
@@ -51,7 +51,7 @@ public synchronized T getData() {

@Override
public Map<String, String> initEnv(Project project) {
return this.definition.initEnv(this.data, project);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @Nullable and @Nonnull to data and getData()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at this stage

Copy link
Member

@Flanker32 Flanker32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andxu andxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangmingliang-ms wangmingliang-ms merged commit fe3aefc into endgame-september Oct 8, 2021
@wangmingliang-ms wangmingliang-ms deleted the hotfix-runmanager branch October 8, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants