Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing voice over sev2s of new database dialog #206

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Fixing voice over sev2s of new database dialog #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/dialogs/newDatabaseDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ export class NewDatabaseDialog {

private onLoadingComplete(): void {
this.databaseNameTextBox.enabled = true;
this.databaseCharsetDropDown.loading = false;
this.databaseCharsetDropDown.enabled = true;
this.databaseCollationDropDown.loading = false;
this.databaseCollationDropDown.enabled = true;
}

Expand All @@ -70,6 +68,7 @@ export class NewDatabaseDialog {

private async loadAndUpdateCharsetValues(): Promise<void> {
try {
this.databaseCharsetDropDown.loading = true;
var charsets: CharsetInfo[] = await ToolsServiceUtils.getCharsets(this.connectionOwnerUri, this.client);
charsets.forEach(charset => {
this.charsetsCache.push(charset.name);
Expand All @@ -81,6 +80,9 @@ export class NewDatabaseDialog {
// Log the error message and keep the values of charset as default.
console.warn("New Database Tab : Unable to fetch charset values. Using default charset.")
}
finally {
this.databaseCharsetDropDown.loading = false;
}
}

private initializeDialog(): void {
Expand Down Expand Up @@ -155,8 +157,7 @@ export class NewDatabaseDialog {
ariaLabel: DatabaseCharsetDropDownLabel,
required: false,
width: '310px',
enabled: false,
loading: true
enabled: false
}).component();

this.databaseCharsetDropDown.onValueChanged(() => {
Expand Down Expand Up @@ -197,8 +198,7 @@ export class NewDatabaseDialog {
ariaLabel: DatabaseCollationDropDownLabel,
required: false,
width: '310px',
enabled: false,
loading: true
enabled: false
}).component();

const databaseCollationLabel = view.modelBuilder.text().withProps({
Expand Down