Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat File Import preview "Refresh" button is unnecessary #6611

Closed
kburtram opened this issue Aug 6, 2019 · 3 comments
Closed

Flat File Import preview "Refresh" button is unnecessary #6611

kburtram opened this issue Aug 6, 2019 · 3 comments

Comments

@kburtram
Copy link
Member

kburtram commented Aug 6, 2019

  • Azure Data Studio Version: master

Steps to Reproduce:

  1. Run Flat File Import wizard and preview the data

Expected: Refresh button does something meaningful. Perhaps refreshing the data after modifying it or with a different schema or something.

Actual: The refresh button re-reads the file without modification. Not sure the use case. I guess if the user manually changed the file on disk while the wizard was running, which seems like a corner-case scenario.

Note: for reference SSMS does not provide a Refresh button on this screen.

ADS screen
image

SSMS screen
image

@aaomidi
Copy link
Contributor

aaomidi commented Aug 6, 2019

I remember we had a reason for getting this. I think the idea was if the user didn't like how ADS treated the data they can edit the file and refresh.

But I agree with you it seems like an extreme edge case!

@kenvanhyning
Copy link
Contributor

IIRC, it also was with the expectation that we would eventually provide options to configure the PROSE library on the preview page. I'll move this to the backlog for now.

@kenvanhyning kenvanhyning added this to the Backlog milestone Aug 7, 2019
aasimkhan30 added a commit that referenced this issue May 1, 2020
- If a PG database is active sending an error
- Removed refresh button #6611
aasimkhan30 added a commit that referenced this issue May 6, 2020
…#10248)

* - Removed PG connections in the new connection wizard
- If a PG database is active sending an error
- Removed refresh button #6611

* Added back the refresh

* -Using getConnection only once.

* -Fixed the error message
-Fixed the bugs mentioned in the PR

Co-authored-by: Aasim Khan <aaskhan@microsoft.com>
@kburtram
Copy link
Member Author

This should be fixed on current builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants