-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto generated Insights of type count include unwanted JSON #80
Comments
Fixes #303, Fixes #304, Fixes #80. * Context menu support in query component - All right-click actions in the grid work in the query editor - Fixed a bug where active grid wasn't reset on new queries. This caused exceptions when a 2nd query had fewer results than the 1st, and you clicked on a grid - keybinding services do not work yet * Create parent class for Edit and Query components * Support Messages context menu * Fixed queryActions tests failing due to missing promises * Fix select and copy actions on messages
Oddly, the tutorial page for custom insights has the incorrect JSON listed in example code and screenshots yet show it to work. Despite that, the bug described above occurs and switching to null or "vertical" does not remedy the lack of text/value in the dashboard grid. |
Hi all, this problem still exists in current build, is there any fix expected? |
@lzimmermann we're planning some improvements in the charting area, though we aren't currently working on this now. This looks like it should be a pretty simple bug we could pick-up before that. Did switching to |
Hi Karl, thanks for contacting me!
No unfortunitly this did not work, but after all there only seem to be warnings - no errors
And I have a great Thank You for you for Building this tool! It is really a great tool and with the ability to be enhanced that simple ist really woth going Forward with the Development!
Kind regards
Lars Zimmermann
PS:
This is my USER SETTINGS which works but has warnings:
{
"workbench.enablePreviewFeatures": true,
"datasource.connectionGroups": [
{
"name": "ROOT",
"id": "C777F06B-202E-4480-B475-FA416154D458"
}
],
"datasource.connections": [
{
"options": {
"connectionName": "",
"server": "sqlserver-.database.windows.net",
"database": "-dev",
"authenticationType": "SqlLogin",
"user": "extern",
"password": "",
"connectTimeout": 30,
"applicationName": "sqlops",
"groupId": "C777F06B-202E-4480-B475-FA416154D458",
"databaseDisplayName": "dev"
},
"groupId": "C777F06B-202E-4480-B475-FA416154D458",
"providerName": "MSSQL",
"savePassword": true,
"id": "c6866d37-235a-4d3d-988c-ef97554e2904"
}
],
"workbench.colorTheme": "Atom One Dark",
"dashboard.database.widgets": [
{
"name": "Slow Queries Widget",
"gridItemConfig": {
"sizex": 2,
"sizey": 1
},
"widget": {
"query-data-store-db-insight": null
}
},
{
"name": "Space Used by Tables",
"gridItemConfig": {
"sizex": 2,
"sizey": 1
},
"widget": {
"table-space-db-insight": null
}
},
{
"name": "My-Widget",
"gridItemConfig": {
"sizex": 2,
"sizey": 1
},
"widget": {
"insights-widget": {
"type": {
"table": {
"dataDirection": "horizontal",
"columnsAsLabels": false,
"labelFirstColumn": true,
"legendPosition": "right"
}
},
"queryFile": "c:\\Users\\larsz\\OneDrive\\Program Files\\ADT Widgets\\WaitTime.sql"
}
}
},
{
"name": "Active Sessions",
"gridItemConfig": {
"sizex": 1,
"sizey": 1
},
"widget": {
"insights-widget": {
"type": {
"count": {
"dataDirection": "vertical",
"dataType": "number",
"legendPosition": "none",
"labelFirstColumn": false,
"columnsAsLabels": false
}
},
"queryFile": "C:\\Users\\larsz\\OneDrive\\Program Files\\ADT Widgets\\ActiveSession.sql",
"details": {
"queryFile": "C:\\Users\\larsz\\OneDrive\\Program Files\\ADT Widgets\\ActiveSessionDetail.sql",
"label": "SID",
"value": "Login Name"
}
}
}
},
{
"name": "Slwoest Queries current Hour",
"gridItemConfig": {
"sizex": 2,
"sizey": 1
},
"widget": {
"insights-widget": {
"type": {
"table": {
"dataDirection": "horizontal",
"columnsAsLabels": false,
"labelFirstColumn": true,
"legendPosition": "top"
}
},
"queryFile": "c:\\Users\\larsz\\OneDrive\\Program Files\\ADT Widgets\\RessourceConsumingQueries.sql"
}
}
}
],
}
Von: Karl Burtram<mailto:notifications@github.com>
Gesendet: Mittwoch, 13. Februar 2019 19:16
An: Microsoft/azuredatastudio<mailto:azuredatastudio@noreply.github.com>
Cc: lzimmermann<mailto:lzimmermann@live.de>; Mention<mailto:mention@noreply.github.com>
Betreff: Re: [Microsoft/azuredatastudio] Auto generated Insights of type count include unwanted JSON (#80)
@lzimmermann<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flzimmermann&data=02%7C01%7C%7C92d15fe0af084049089008d691df60eb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636856785912921479&sdata=9E28TP01xp2PvOw8PZDqbz0xMSnl5pGYGFYDTwwwJjA%3D&reserved=0> we're planning some improvements in the charting area, though we aren't currently working on this now. This looks like it should be a pretty simple bug we could pick-up before that.
Did switching to "count": null resolve the problem for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazuredatastudio%2Fissues%2F80%23issuecomment-463307779&data=02%7C01%7C%7C92d15fe0af084049089008d691df60eb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636856785912931490&sdata=Df6RvPjoHM617QZgLocsu9sQAjilkmtSfbmaPJHMyuQ%3D&reserved=0>, or mute the thread<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBiUQOCM92B987VLvdAZaM7yc4-_M2wks5vNFZ-gaJpZM4QgtMS&data=02%7C01%7C%7C92d15fe0af084049089008d691df60eb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636856785912941489&sdata=oW60iRexTmKQVHxt30mPyKj9zrWhcjsdcnyDreabHfI%3D&reserved=0>.
|
Closing older issues. We're moving in a slightly different direction with dashboarding and custom widgets in future releases that will resolve problems such as this. |
Steps to Reproduce:
What I see:
"count": {
"dataDirection": "vertical",
"dataType": "number",
"legendPosition": "none",
"labelFirstColumn": false,
"columnsAsLabels": false
}
What I expect:
"count": null
The text was updated successfully, but these errors were encountered: